0032949: Modeling Algorithms - Infinite loop in ShapeUpgrade_UnifySameDomain

Problem occurs when InternalEdges is empty but the vertices from VV is not same. Added condition to stop the loop when InternalEdges is empty.
2025-08-09 13:22:24 +03:00 · 2023-09-18 16:56:05 +01:00
1 changed files with 5 additions and 2 deletions
--- a/src/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
+++ b/src/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
@@ -3708,8 +3708,11 @@ void ShapeUpgrade_UnifySameDomain::IntUnifyFaces(const TopoDS_Shape& theInpShape
              TopoDS_Edge anEdge = TopoDS::Edge(itl.Value());
              if (anEdge.IsSame(EndEdges[ii]))
                continue;
-              found = Standard_True;
-              InternalEdges.RemoveKey(anEdge);
+              found = InternalEdges.RemoveKey(anEdge);
+              if (!found)
+              {
+                break;
+              }
              BB.Add(anInternalWire, anEdge);
              TopoDS_Vertex V1, V2;
              TopExp::Vertices(anEdge, V1, V2);