Additional fix for 29713

0029713: Test Harness command "fixshape" can not fix attached face
Fix to reverse invalid oriented pcurves was made
2025-08-09 13:22:24 +03:00 · 2018-04-25 19:42:27 +03:00 · 2018-04-23 16:41:44 +03:00
1 changed files with 8 additions and 8 deletions
--- a/src/ShapeAnalysis/ShapeAnalysis_Edge.cxx
+++ b/src/ShapeAnalysis/ShapeAnalysis_Edge.cxx
@@ -438,7 +438,7 @@ Standard_Boolean ShapeAnalysis_Edge::CheckCurve3dWithPCurve (const TopoDS_Edge&
  TopoDS_Vertex aFirstVert = FirstVertex (edge);
  TopoDS_Vertex aLastVert  = LastVertex (edge);

-  if (aFirstVert.IsNull() || aLastVert.IsNull())
+  if (aFirstVert.IsNull() || aLastVert.IsNull() || aFirstVert.IsSame(aLastVert))
    return Standard_False;

  Standard_Real preci1 = BRep_Tool::Tolerance (aFirstVert),
@@ -469,13 +469,13 @@ Standard_Boolean ShapeAnalysis_Edge::CheckPoints (const gp_Pnt& P1A,
 						  const Standard_Real preci2) 
 {
  myStatus = ShapeExtend::EncodeStatus (ShapeExtend_OK);
-  if (P1A.SquareDistance (P2A) <= preci1 * preci1 &&
-      P1B.SquareDistance (P2B) <= preci2 * preci2)
-    return Standard_False;
-  else if (P1A.Distance (P2B) + (P1B.Distance (P2A)) <
-	   P1A.Distance (P2A) + (P1B.Distance (P2B)))
-    myStatus |= ShapeExtend::EncodeStatus (ShapeExtend_DONE1);
-  return Standard_True;
+  if( (P1A.SquareDistance(P2B) < P1A.SquareDistance(P2A) ) && 
+    ( P1B.SquareDistance(P2A) < P1B.SquareDistance(P2B)) )
+ {
+    myStatus |= ShapeExtend::EncodeStatus(ShapeExtend_DONE1);
+    return Standard_True;
+  }
+  return Standard_False;
 }
Author	SHA1	Message	Date
gka	c30097d4ce	Additional fix for 29713	2018-04-25 19:42:27 +03:00
gka	871a52cf1b	0029713: Test Harness command "fixshape" can not fix attached face Fix to reverse invalid oriented pcurves was made	2018-04-23 16:41:44 +03:00