1
0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-14 13:30:48 +03:00

Compare commits

...

1 Commits

Author SHA1 Message Date
akaftasev
1083b94cf9 0033418: Modeling Algorithms - BRepExtrema_DistShapeShape wrong arc ellipse - point result
Wrong calculation of distance arises for ellipse with MajorRadius == MinorRadius when first or last parameter of trimmed ellipse more then 2*pi
This case should be calculated as circle
2023-08-04 10:04:44 +01:00
2 changed files with 23 additions and 0 deletions

View File

@@ -217,6 +217,10 @@ Method:
Then, (1) <=> (A*Cos-X,B*Sin-Y).(-A*Sin,B*Cos) = 0.
(B**2-A**2)*Cos*Sin - B*Y*Cos + A*X*Sin = 0.
Use algorithm math_TrigonometricFunctionRoots to solve this equation.
Addition:
In case, when MajorRadius == MinorRadius calcualtion errors may occur
This case should be processed as Circle
-----------------------------------------------------------------------------*/
{
myDone = Standard_False;
@@ -229,6 +233,12 @@ Method:
gp_Vec Trsl = Axe.Multiplied(-(gp_Vec(O,P).Dot(Axe)));
gp_Pnt Pp = P.Translated(Trsl);
if (Abs(C.MajorRadius() - C.MinorRadius() < Precision::Confusion()))
{
Perform(P, gp_Circ(gp_Ax2(O, C.Axis().Direction()), C.MajorRadius()), Tol, Uinf, Usup);
return;
}
// 2- Calculation of solutions ...
Standard_Integer NoSol, NbSol;

View File

@@ -0,0 +1,13 @@
puts "================================================================="
puts "0033418: Modeling Algorithms - BRepExtrema_DistShapeShape wrong arc ellipse - point result"
puts "================================================================="
puts ""
ellipse el 0 0 0 0 1 0 1 1
trim el el 4.71238898038 1.57079632679
mkedge el el
vertex v 0 0 1.5
distmini d el v
if {[dval d_val] > 0.5000001} {
puts "ERROR: Wrong distance calculation"
}