0030873: Make ReShape tool resistant to replacement loops

2025-08-14 13:30:48 +03:00 · 2019-08-07 13:25:15 +02:00
1 changed files with 9 additions and 0 deletions
--- a/src/BRepTools/BRepTools_ReShape.cxx
+++ b/src/BRepTools/BRepTools_ReShape.cxx
@@ -156,6 +156,13 @@ void BRepTools_ReShape::replace (const TopoDS_Shape& ashape,
  TopoDS_Shape shape = ashape;
  TopoDS_Shape newshape = anewshape;
  if ( shape.IsNull() || shape == newshape ) return;
+  if (Apply (newshape) == shape) 
+  {
+#ifdef OCCT_DEBUG
+    cout << "Warning: BRepTools_ReShape::Replace: recording the shape will lead to a loop" << endl;
+#endif
+    return;
+  }

  if (shape.Orientation() == TopAbs_REVERSED)
  {
@@ -181,7 +188,9 @@ void BRepTools_ReShape::replace (const TopoDS_Shape& ashape,
 #ifdef OCCT_DEBUG
  if ( IsRecorded ( shape ) && ((myConsiderLocation && ! Value ( shape ).IsPartner ( newshape )) ||
                                 (!myConsiderLocation && ! Value ( shape ).IsSame ( newshape )))) 
+  {
    cout << "Warning: BRepTools_ReShape::Replace: shape already recorded" << endl;
+  }
 #endif

  myShapeToReplacement.Bind(shape, TReplacement(newshape, theKind));