# IsHilighted by owner should use the same logic like when it is highlighted. IsSelected is used for selection state, not highlight.
#
# Without this correction, object is never shown as selected by click (Select(bool)):
# if (!HighlightStyle (theOwner, aCustomStyle) ||
# (!aCustomStyle.IsNull() && aCustomStyle != anObjSelStyle))
# IsSelected is already true, so the highlight style is equal to selection style, nothing to do.
(cherry picked from commit b3d449ff2f7b8ed5afba33106d045427d2c146de)
TreeModel is extended by ItemPropertiesCreator (to customize items/panes outside tools),
ViewControl have TransientShape to use in interface TopoDS_Shape as a Handle(Standard_Transient)
ShapeView start of curve description for edge item
The previous code has a condition to avoid processing the same faces if the face has a location.
The similar condition should be applied during the edges processing.
If not doing this, in the previous implementation, IMeshData_Edge instances are created for all edges(even located), but edges of faces located are not filled with curves.
As a result we had wrong local selection of edges.
Limit addition of edges to data model by ones with unique TShape and location using edges map already available in BRepMesh_ShapeVisitor.
(cherry picked from commit 967d2f4f30)
- implement "Explode" context menu action on a shape item in tree view. Calling this action cases build of the item subtree using TopExp::MapShapes by the type. (By default the tree generating uses TopoDS_Iterator)
- display properties of a selected tree item in Property Panel. (Similar to DFBrowser plugin).
(cherry picked from commit 2b4094183df26dfe0dae62f63822d7bf6d2214c6)
(cherry picked from commit a93268ba6cbde85f311fe698e186ea41da05efc2)
Modifications:
- Message_AlertExtended to store additional parameters (attributes, composite alert container, performance meter)
- Message_Attribute and inherited classes to store custom information about alert
- Message_CompositeAlerts to have hierarchical structure of alerts
- Message_PerfMeter to automatically calculate time between alerts adding into report
- Message_ReportCall back to be able to react to message report filling.
- Import/Export message report report. Currently it is implemented using XmlDrivers_MessageReportStorage
- MessageView/MessageModel - Inspector plugin for GUI presentation of Message_Report
Sample of using alerts:
- BRepMesh_IncremetalMesh - till IMeshTools_ShapeExplorer::Accept() for model maps filling (debug of 0030497 issue)
DRAW case:
- tools/messageview/A1
(cherry picked from commit 9dae9d43ba992a094fb387648bcd5503b487f698)
(cherry picked from commit 2e08eac5a39c627a87dbe3b23df51c8178a6ad5f)
The previous code has a condition to avoid processing the same faces if the face has a location.
The similar condition should be applied during the edges processing.
If not doing this, in the previous imlementation, IMeshData_Edge instances are created for all edges(even located), but edges of faces located are not filled with curves.
As a result we had wrong local selection of edges.
(cherry picked from commit 9e00d610b88e4f1778a5a55fe9c50d2665169d28)
Modifications:
- Message_AlertExtended to store additional parameters (attributes, composite alert container, performance meter)
- Message_Attribute and inherited classes to store custom information about alert
- Message_CompositeAlerts to have hierarchical structure of alerts
- Message_PerfMeter to automatically calculate time between alerts adding into report
- Message_ReportCall back to be able to react to message report filling.
- Import/Export message report report. Currently it is implemented using XmlDrivers_MessageReportStorage
- MessageView/MessageModel - Inspector plugin for GUI presentation of Message_Report
(cherry picked from commit e4529dcf83b12759e47efb89ded8207f802556a7)
Conflicts:
tools/ViewControl/FILES
tools/ViewControl/ViewControl_PropertyView.cxx
tools/ViewControl/ViewControl_PropertyView.hxx
tools/ViewControl/ViewControl_Table.cxx
tools/ViewControl/ViewControl_Table.hxx
tools/ViewControl/ViewControl_TableModel.hxx
tools/ViewControl/ViewControl_TableModelFilter.cxx
tools/ViewControl/ViewControl_TableModelFilter.hxx
tools/ViewControl/ViewControl_TableModelValues.hxx
tools/ViewControl/ViewControl_TableProperty.cxx
tools/ViewControl/ViewControl_TableProperty.hxx
tools/ViewControl/ViewControl_Tools.cxx
tools/ViewControl/ViewControl_Tools.hxx
- VInspectorPaneAIS - to create additional rows for custom AIS presentations in property table, example is a table for AIS_Shape
(ViewControl_PaneCreator/PaneItem interface for it, to be used in DFBrowser instead of DFBrowserPane_Creator)
- VInspector items for: Select3D_SensitiveSet, Graphics3d_CView, Graphic3d_Camera, Aspect_Window objects
- VInspector camera follower presentation - draft.
Modifications in src:
implementing methods to have text information for some of OCCT enums;
moving out the text information from Quantity_Color;
expansionFactor() in Graphic3d_AspectText3d for access to this parameter;
Modifications in tools:
implementing common controls in ViewControl to be used in all plugins: table, property view and color selector;
move properties from columns of VInspector into property view, filled by tree view item selecting;
implementing new items (aspects, graphical information)
extending information of already existing items (presentations, selection entities)
display preview presentation for selected item (if possible, GetPresentations or GetPresentationShape of the item returns not empty value)
(cherry picked from commit 6dce71df876075a54ca7ef0a267fdbbdfceb6ac8)
Added new class AIS_ViewCube implementing interactive cube displaying orientation of the main axes of the model space in the viewer.
Each side, edge, or corner of the cube corresponds to particular orientation of the camera, and the class provides methods to move the camera to corresponding position (with animation if needed).
DRAW command vviewcube is added to use the cube in DRAW.
(cherry picked from commit cd47b946ed397b421d24a19da1928cd4d2391533)
In fact, the DRAW-command "mesh" is duplicate of "incmesh".
The difference is that the "mesh" creates DRAW-object MeshTest_DrawableMesh. However, this object is currently not applicable (e.g. we cannot display it).
DRAW-commands "mesh", "addshape", "smooth", "edges", "vertices", "medge", "mvertex", "triangle", "dumpvertex", "dumpedge", "dumptriangle" and "onetriangulation" have been removed.
The class MeshTest_DrawableMesh has been removed as useless.
Testgrids "mesh standard_mesh" and "mesh advanced_mesh" have been removed.
Before the fix, angular deflection was scaled to some coefficient in the method BRepMesh_Deflection::ComputeDeflection(...). Now, angular deflection is constant.
1. Check whether the mesh satisfies the required angular deflection has been amended. Namely normals (to the surface) in the ends of any not "frontier" link are made collinear (with the given angular tolerance).
2. New parameters AngleInterior and DeflectionInterior have been added in IMeshTools_Parameters structure.
3. In case of thin long faces with internal edges, add points of internal edges to control parameters using grabParamsOfInternalEdges() in order to avoid aberrations on its ends. Disable addition of parameters from boundary edges in case of BSpline surface. Deviation can be controlled through the deflection parameter.
4. Grab parameters from edges in case if there is just a single interval on BSpline surface along U and V direction.
Removed tight connections between data structures, auxiliary tools and algorithms in order to create extensible solution, easy for maintenance and improvements;
Code is separated on several functional units responsible for specific operation for the sake of simplification of debugging and readability;
Introduced new data structures enabling possibility to manipulate discrete model of particular entity (edge, wire, face) in order to perform computations locally instead of processing an entire model.
The workflow of updated component can be divided on six parts:
* Creation of model data structure: source TopoDS_Shape passed to algorithm is analyzed and exploded on faces and edges. For each topological entity corresponding reflection is created in data model. Note that underlying algorithms use data model as input and access it via common interface which allows user to create custom data model with necessary dependencies between particular entities;
* Discretize edges 3D & 2D curves: 3D curve as well as associated set of 2D curves of each model edge is discretized in order to create coherent skeleton used as a base in faces meshing process. In case if some edge of source shape already contains polygonal data which suites specified parameters, it is extracted from shape and stored to the model as is. Each edge is processed separately, adjacency is not taken into account;
* Heal discrete model: source TopoDS_Shape can contain problems, such as open-wire or self-intersections, introduced during design, exchange or modification of model. In addition, some problems like self-intersections can be introduced by roughly discretized edges. This stage is responsible for analysis of discrete model in order to detect and repair faced problems or refuse model’s part for further processing in case if problem cannot be solved;
* Preprocess discrete model: defines actions specific for implemented approach to be performed before meshing of faces. By default, iterates over model faces and checks consistency of existing triangulations. Cleans topological faces and its adjacent edges from polygonal data in case of inconsistency or marks face of discrete model as not required for computation;
* Discretize faces: represents core part performing mesh generation for particular face based on 2D discrete data related to processing face. Caches polygonal data associated with face’s edges in data model for further processing and stores generated mesh to TopoDS_Face;
* Postprocess discrete model: defines actions specific for implemented approach to be performed after meshing of faces. By default, stores polygonal data obtained on previous stage to TopoDS_Edge objects of source model.
Component is now spread over IMeshData, IMeshTools, BRepMeshData and BRepMesh units.
<!break>
1. Extend "tricheck" DRAW-command in order to find degenerated triangles.
2. Class BRepMesh_FastDiscret::Parameters has been declared as deprecated.
3. NURBS range splitter: do not split intervals without necessity. Intervals are split only in case if it is impossible to compute normals directly on intervals.
4. Default value of IMeshTools_Parameters::MinSize has been changed. New value is equal to 0.1*Deflection.
5. Correction of test scripts:
1) perf mesh bug27119: requested deflection is increased from 1e-6 to 1e-5 to keep reasonable performance (but still reproducing original issue)
2) bugs mesh bug26692_1, 2: make snapshot of triangulation instead of wireframe (irrelevant)
Correction in upgrade guide.
Boolean Operations - Force the face with internal edges to be treated by the BuilderFace algorithm. It is needed for the cases when internal edges of the face go from side to side and should really split the face.
Test case for the issue.
If 2D-curves are requested in intersection result but they cannot be created (by some reason) then the full set of curves (3D and two 2D) is rejected from the intersection result.
