OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0032329: Modeling Algorithms - Refactoring of the BRepOffset_MakeOffset_1.cxx to decrease number of static methods

Browse Source 
Refactoring of the BRepOffset_MakeOffset_1.cxx - Introduce local class BRepOffset_BuildOffsetFaces to compute splits of offset faces.

Change of tests is caused by the correction of the misprint in the code (incorrect input parameter for CheckEdgesCreatedByVertex method).
This commit is contained in:
emv 2021-07-12 14:27:01 +03:00 committed by bugmaster
parent acab849d30
commit b7344f5d72
8 changed files with 4122 additions and 3835 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/BRepOffset/BRepOffset_MakeOffset.hxx
View File

@ -217,7 +217,7 @@ private:
//! Currently the Complete intersection mode is limited to work only on planar cases.
Standard_EXPORT void BuildSplitsOfExtendedFaces(const TopTools_ListOfShape& theLF,
const BRepOffset_Analyse& theAnalyse,
Handle(BRepAlgo_AsDes)& theAsDes,
const Handle(BRepAlgo_AsDes)& theAsDes,
TopTools_DataMapOfShapeListOfShape& theEdgesOrigins,
TopTools_DataMapOfShapeShape& theFacesOrigins,
TopTools_DataMapOfShapeShape& theETrimEInf,
@ -226,7 +226,7 @@ private:
//! Building of the splits of the already trimmed offset faces for mode Complete
//! and joint type Intersection.
Standard_EXPORT void BuildSplitsOfTrimmedFaces(const TopTools_ListOfShape& theLF,
Handle(BRepAlgo_AsDes)& theAsDes,
const Handle(BRepAlgo_AsDes)& theAsDes,
BRepAlgo_Image& theImage);
Standard_Real myOffset;

7896
src/BRepOffset/BRepOffset_MakeOffset_1.cxx
View File

File diff suppressed because it is too large Load Diff

11
tests/offset/shape_type_i_c/XE3
View File

@ -1,11 +1,10 @@
puts "TODO OCC27414 ALL: Error: The command cannot be built"
puts "TODO OCC27414 ALL: gives an empty result"
puts "TODO OCC27414 ALL: TEST INCOMPLETE"
restore [locate_data_file bug26917_dom-7724_trim1.brep] s
OFFSETSHAPE 15 {} $calcul $type
checkprops result -v 0 -s 0
checkprops result -s 514521 -v 9.46497e+06
checknbshapes result -shell 1
unifysamedom result_unif result
checknbshapes result_unif -wire 24 -face 24 -shell 1 -solid 1
checkview -display result_unif -2d -path ${imagedir}/${test_image}.png

11
tests/offset/shape_type_i_c/XE4
View File

@ -1,11 +1,10 @@
puts "TODO OCC27414 ALL: Error: The command cannot be built"
puts "TODO OCC27414 ALL: gives an empty result"
puts "TODO OCC27414 ALL: TEST INCOMPLETE"
restore [locate_data_file bug26917_dom-7724_trim2.brep] s
OFFSETSHAPE 15 {} $calcul $type
checkprops result -v 0 -s 0
checkprops result -s 218663 -v 3.41078e+06
checknbshapes result -shell 1
unifysamedom result_unif result
checknbshapes result_unif -wire 24 -face 24 -shell 1 -solid 1
checkview -display result_unif -2d -path ${imagedir}/${test_image}.png

11
tests/offset/shape_type_i_c/XE9
View File

@ -1,11 +1,10 @@
puts "TODO OCC27414 ALL: Error: The command cannot be built"
puts "TODO OCC27414 ALL: gives an empty result"
puts "TODO OCC27414 ALL: TEST INCOMPLETE"
restore [locate_data_file bug26917_dom-7724_trim8.brep] s
OFFSETSHAPE 15 {} $calcul $type
checkprops result -v 0 -s 0
checkprops result -s 288599 -v 5.26099e+06
checknbshapes result -shell 1
unifysamedom result_unif result
checknbshapes result_unif -wire 25 -face 25 -shell 1 -solid 1
checkview -display result_unif -2d -path ${imagedir}/${test_image}.png

11
tests/offset/shape_type_i_c/XF2
View File

@ -1,11 +1,10 @@
puts "TODO OCC27414 ALL: Error: The command cannot be built"
puts "TODO OCC27414 ALL: gives an empty result"
puts "TODO OCC27414 ALL: TEST INCOMPLETE"
restore [locate_data_file bug26917_dom-7724_trim10.brep] s
OFFSETSHAPE 15 {} $calcul $type
checkprops result -v 0 -s 0
checkprops result -s 191910 -v 3.1661e+06
checknbshapes result -shell 1
unifysamedom result_unif result
checknbshapes result_unif -wire 19 -face 19 -shell 1 -solid 1
checkview -display result_unif -2d -path ${imagedir}/${test_image}.png

11
tests/offset/shape_type_i_c/XU3
View File

@ -1,7 +1,3 @@
puts "TODO OCC27414 ALL: Error: The command cannot be built"
puts "TODO OCC27414 ALL: gives an empty result"
puts "TODO OCC27414 ALL: TEST INCOMPLETE"
puts "========"
puts "0031307: Modeling Algorithms - Offset algorithm produces incorrect result in mode Complete join type Intersection"
puts "========"
@ -15,8 +11,7 @@ offsetonface s_9 7
offsetperform result
checkprops result -s 222993 -v 1.87721e+06
checknbshapes result -shell 1 -solid 1
#unifysamedom result_unif result
#checknbshapes result_unif -vertex 26 -edge 39 -wire 15 -face 15 -shell 1 -solid 1
#checkview -display result_unif -2d -path ${imagedir}/${test_image}.png
unifysamedom result_unif result
checknbshapes result_unif -vertex 26 -edge 39 -wire 15 -face 15 -shell 1 -solid 1
checkview -display result_unif -2d -path ${imagedir}/${test_image}.png

2
tests/offset/shape_type_i_c/ZS1
View File

@ -7,4 +7,4 @@ offsetperform result
checkprops result -s 6.21471e+06 -v 8.95633e+08
unifysamedom result_unif result
checknbshapes result_unif -wire 142 -face 140 -shell 1 -solid 1
checknbshapes result_unif -wire 140 -face 138 -shell 1 -solid 1