OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-04 13:13:25 +03:00
Code Activity

0030550: Coding - Integer overflow in Standard_CString HashCodes

Browse Source 
0030551: Foundation Classes - Integer overflow in NCollection_CellFilter HashCode

Signed integers are not used in hash code functions now to prevent undefined behavior on left shift operations with signed integers.
A possibility of negative values of hash codes is eliminated.
INT_MAX → IntegerLast() in hash code functions.
All found hash code functions behaves uniformly now: they return a value in the range [1, theUpperBound]. Relevant comments are added to such functions.
This commit is contained in:
tiv
2019-03-28 12:42:41 +03:00
committed by bugmaster
parent 833034f301
commit 2b2be3fb82
89 changed files with 878 additions and 580 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/OSD/OSD_Thread.cxx
View File

@@ -144,9 +144,10 @@ Standard_Boolean OSD_Thread::Run (const Standard_Address data,
adata->func = myFunc;
// then try to create a new thread
DWORD aThreadId = DWORD();
myThread = CreateThread ( NULL, WNTStackSize, WNTthread_func,
adata, 0, &myThreadId );
adata, 0, &aThreadId );
myThreadId = aThreadId;
if ( myThread )
SetThreadPriority (myThread, myPriority);
else {
@@ -162,7 +163,7 @@ Standard_Boolean OSD_Thread::Run (const Standard_Address data,
}
else
{
myThreadId = myThread;
myThreadId = (Standard_ThreadId)myThread;
}
#endif
return myThread != 0;
@@ -328,6 +329,6 @@ Standard_ThreadId OSD_Thread::Current ()
#ifdef _WIN32
return GetCurrentThreadId();
#else
return pthread_self();
return (Standard_ThreadId)pthread_self();
#endif
}