OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0026687: SIGSEGV in BRepBuilderAPI_MakeFace

Browse Source 
1. Check face location has been added.
2. Message, if mkplane command fails, has been added.
3. Test case for this issue has been created.

Changes in accordance with the remark.

Small correction of test case for issue CR26687
This commit is contained in:
nbv 2015-09-17 13:52:17 +03:00 committed by bugmaster
parent 363bc51b20
commit 1f0adf314d
3 changed files with 47 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/BRepLib/BRepLib_FindSurface.cxx
View File

@ -118,6 +118,7 @@ static Standard_Boolean Is2DClosed(const TopoDS_Shape& theShape,
{
try
{
OCC_CATCH_SIGNALS
// get a wire theShape
TopExp_Explorer aWireExp( theShape, TopAbs_WIRE );
if ( !aWireExp.More() ) {
@ -225,7 +226,7 @@ void BRepLib_FindSurface::Init(const TopoDS_Shape& S,
if (SS.IsNull()) {
break;
}
if (SS == mySurface) {
if ((SS == mySurface) && (L.IsEqual(myLocation))) {
break;
}
SS.Nullify();

27
src/BRepTest/BRepTest_SurfaceCommands.cxx
View File

@ -180,7 +180,7 @@ static Standard_Integer mksurface(Draw_Interpretor& , Standard_Integer n, const
// mkplane
//=======================================================================
static Standard_Integer mkplane(Draw_Interpretor& , Standard_Integer n, const char** a)
static Standard_Integer mkplane(Draw_Interpretor& theDI, Standard_Integer n, const char** a)
{
if (n < 3) return 1;
@ -192,9 +192,30 @@ static Standard_Integer mkplane(Draw_Interpretor& , Standard_Integer n, const ch
OnlyPlane = !strcmp(a[3],"1");
}
TopoDS_Face F = BRepBuilderAPI_MakeFace(TopoDS::Wire(S), OnlyPlane);
BRepBuilderAPI_MakeFace aMF(TopoDS::Wire(S), OnlyPlane);
switch(aMF.Error())
{
case BRepBuilderAPI_FaceDone:
DBRep::Set(a[1],aMF.Face());
break;
case BRepLib_NoFace:
theDI << "Error. mkplane has been finished with \"No Face\" status.\n";
break;
case BRepLib_NotPlanar:
theDI << "Error. mkplane has been finished with \"Not Planar\" status.\n";
break;
case BRepLib_CurveProjectionFailed:
theDI << "Error. mkplane has been finished with \"Fail in projection curve\" status.\n";
break;
case BRepLib_ParametersOutOfRange:
theDI << "Error. mkplane has been finished with \"Parameters are out of range\" status.\n";
break;
default:
theDI << "Error. Undefined status. Please check the code.\n";
break;
}
DBRep::Set(a[1],F);
return 0;
}

21
tests/bugs/modalg_6/bug26687 Executable file
View File

@ -0,0 +1,21 @@
puts "REQUIRED: Error. mkplane has been finished with \"Not Planar\" status."
puts "========"
puts "OCC26687"
puts "========"
puts ""
#################################################
# 0026687: SIGSEGV in BRepBuilderAPI_MakeFace
#################################################
restore [locate_data_file bug26687_w.brep] w
#It is impossible to create a plane there is no any surface
#which every edge has its p-cuve in.
mkplane f w
smallview
donly f
fit
xwd ${imagedir}/${test_image}.png