mirror of
https://git.dev.opencascade.org/repos/occt.git
synced 2025-04-07 18:30:55 +03:00
e2e0498b17
The root of the problem is incorrect processing of cases when intersection line goes through the apex(es) of sphere. The fix improves this situation. The algorithm is taken from DecomposeResult(...) function (see IntPatch_ImpPrmIntersection.cxx file). Before the fix, faltering steps were done to solve this problem. As result, it worked in some particular cases. Now, its possibilities have been extended significantly. Following changes have been made in the fix: 1. Class IntPatch_ALineToWLine has been rewritten cardinally. It touches as interfaces of existing methods as adding/removing some methods/fields. Correction touches both cases: going through seam of Cone/Sphere and through pole(s) of sphere. Old interface did not allow making some actions with analytical line (ALine), e.g. splitting it on several Walking-lines (WLine). 2. Restriction-line support has been removed from Implicit-Implicit intersection result (see IntPatch_Intersection::GeomGeomPerfom(...) method). It connects with the fact that the intersection algorithm itself returns precise intersection line in analytical cases (in compare with parametric intersector). Therefore, we do not need in additional (restriction) line. 3. New class IntPatch_SpecialPoints has been added. This class contains methods to add some special points (such as apex of cone, pole of sphere, point on surface boundary etc.) in intersection line (IntPatch_PointLine). It is based on the static functions, which already exist in IntPatch_ImpPrmIntersection.cxx file (these functions have been moved to the new class). 4. Method IntPatch_WLineTool::ExtendTwoWlinesToEachOther(...) has been renamed to IntPatch_WLineTool::ExtendTwoWLines(...). It is connected with changing main idea of the method. Now it allows extending WLine to the surface boundary or to the singular point (if it is possible): cone apex, sphere pole etc. Interface of this method has been corrected, too. At that, old functionality (extending to each other) has been kept. For implementation of this algorithm, new enumeration "IntPatchWT_WLsConnectionType" has been created. 5. Method IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) has been added. See IntPatch_PointLine.hxx for detail information. It allows correct step computing depended on the local curvature of the intersection line. This method uses geometrical properties of intersected surfaces to compute local curvature. Therefore, it can be applied in wide range of cases even if the intersection curve is not represented in explicit form (e.g. in case of param-param-intersection). 6. Method IntSurf::SetPeriod(...) has been created. 7. Additional check has been added in Draft_Modification::Perform() method for better choice of correct fragment of intersection line for processing DRAFT operation. 8. New overload method IntPatch_Point::SetValue() has been added. 9. Some refactoring of the code has been made. Creation of test case for issue #27431. --------------------------------------------------------------------------------------------- Some test cases have been adjusted according to their new behavior. tests\bugs\modalg_4\bug62 It is really IMPROVEMENT (but fortuitous). tests\bugs\modalg_5\bug25838 The behavior of this test has been reverted to the state before fixing the issue #27341. Main problem has not been fixed in #27341. It was fortuitous improvement. tests\bugs\moddata_2\bug565 Quality of intersection curve was not checked. And the curve is bad on both MASTER and FIX. Input data are really wrong: plane-like-cone. However, on the MASTER, four intersection curves (the quality is insignificant) are expected. On the fix, not empty intersection result is expected simply. tests\boolean\volumemaker\A8 Differences in images and CPU is expected. Difference in images is expected to be fixed in the issue #26020. Now, we should apply this behavior. Much CPU time is spent by IntTools_FaceFace::ComputeTolReached3d(...) and GeomInt_IntSS::BuildPCurves(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too. tests\boolean\volumemaker\F8 tests\boolean\volumemaker\F9 tests\boolean\volumemaker\G5 tests\boolean\volumemaker\G6 CPU difference is expected. Much CPU time is spent by IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) method calling. This method is really new (it does not exist on the MASTER) and is really useful. Therefore, we should apply new behavior. tests\boolean\volumemaker\G1 CPU difference is expected. Much CPU time is spent by IntTools_WLineTool::DecompositionOfWLine(...) and IntTools_FaceFace::ComputeTolReached3d(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too. tests\bugs\modalg_6\bug26619 Differences in images is expected. The test keeps its BAD status on the FIX. But the result on the fix is nearer to expected than on the MASTER. Issue #27014 is still actual. As before, it is not clear, why the number of entities is different. The number of section curves has not been changed. Interfered entities are the same as on the MASTER. tests\bugs\modalg_5\bug25319_1(2) The reason is described in the issue #27896. Small correction in the test case
107 lines
4.1 KiB
C++
107 lines
4.1 KiB
C++
// Created on: 1993-11-26
|
|
// Created by: Modelistation
|
|
// Copyright (c) 1993-1999 Matra Datavision
|
|
// Copyright (c) 1999-2014 OPEN CASCADE SAS
|
|
//
|
|
// This file is part of Open CASCADE Technology software library.
|
|
//
|
|
// This library is free software; you can redistribute it and/or modify it under
|
|
// the terms of the GNU Lesser General Public License version 2.1 as published
|
|
// by the Free Software Foundation, with special exception defined in the file
|
|
// OCCT_LGPL_EXCEPTION.txt. Consult the file LICENSE_LGPL_21.txt included in OCCT
|
|
// distribution for complete text of the license and disclaimer of any warranty.
|
|
//
|
|
// Alternatively, this file may be used under the terms of Open CASCADE
|
|
// commercial license or contractual agreement.
|
|
|
|
#ifndef _IntPatch_ALineToWLine_HeaderFile
|
|
#define _IntPatch_ALineToWLine_HeaderFile
|
|
|
|
#include <IntPatch_SequenceOfLine.hxx>
|
|
#include <IntSurf_Quadric.hxx>
|
|
#include <Standard_DefineAlloc.hxx>
|
|
#include <Standard_Handle.hxx>
|
|
#include <Standard_Macro.hxx>
|
|
|
|
class Adaptor3d_HSurface;
|
|
class IntPatch_ALine;
|
|
class IntSurf_PntOn2S;
|
|
|
|
class IntPatch_ALineToWLine
|
|
{
|
|
public:
|
|
|
|
DEFINE_STANDARD_ALLOC
|
|
|
|
//! Constructor
|
|
Standard_EXPORT IntPatch_ALineToWLine(const Handle(Adaptor3d_HSurface)& theS1,
|
|
const Handle(Adaptor3d_HSurface)& theS2,
|
|
const Standard_Integer theNbPoints = 200);
|
|
|
|
Standard_EXPORT void SetTolOpenDomain (const Standard_Real aT);
|
|
|
|
Standard_EXPORT Standard_Real TolOpenDomain() const;
|
|
|
|
Standard_EXPORT void SetTolTransition (const Standard_Real aT);
|
|
|
|
Standard_EXPORT Standard_Real TolTransition() const;
|
|
|
|
Standard_EXPORT void SetTol3D (const Standard_Real aT);
|
|
|
|
Standard_EXPORT Standard_Real Tol3D() const;
|
|
|
|
//! Converts aline to the set of Walking-lines and adds
|
|
//! them in theLines.
|
|
Standard_EXPORT void MakeWLine (const Handle(IntPatch_ALine)& aline,
|
|
IntPatch_SequenceOfLine& theLines) const;
|
|
|
|
//! Converts aline (limitted by paraminf and paramsup) to the set of
|
|
//! Walking-lines and adds them in theLines.
|
|
Standard_EXPORT void MakeWLine (const Handle(IntPatch_ALine)& aline,
|
|
const Standard_Real paraminf,
|
|
const Standard_Real paramsup,
|
|
IntPatch_SequenceOfLine& theLines) const;
|
|
|
|
protected:
|
|
//! Computes step value to construct point-line. The step depends on
|
|
//! the local curvature of the intersection line computed in thePOn2S.
|
|
//! theTgMagnitude is the magnitude of tangent vector to the intersection
|
|
//! line (in the point thePOn2S).
|
|
//! Computed step is always in the range [theStepMin, theStepMax].
|
|
//! Returns FALSE if the step cannot be computed. In this case, its value
|
|
//! will not be changed.
|
|
Standard_EXPORT Standard_Boolean StepComputing(const Handle(IntPatch_ALine)& theALine,
|
|
const IntSurf_PntOn2S& thePOn2S,
|
|
const Standard_Real theLastParOfAline,
|
|
const Standard_Real theCurParam,
|
|
const Standard_Real theTgMagnitude,
|
|
const Standard_Real theStepMin,
|
|
const Standard_Real theStepMax,
|
|
const Standard_Real theMaxDeflection,
|
|
Standard_Real& theStep) const;
|
|
|
|
|
|
Standard_EXPORT Standard_Integer CheckDeflection(const gp_XYZ& theMidPt,
|
|
const Standard_Real theMaxDeflection) const;
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
|
Handle(Adaptor3d_HSurface) myS1;
|
|
Handle(Adaptor3d_HSurface) myS2;
|
|
IntSurf_Quadric myQuad1;
|
|
IntSurf_Quadric myQuad2;
|
|
|
|
//! Approximate number of points in resulting
|
|
//! WLine (precise number of points is computed
|
|
//! by the algorithms)
|
|
Standard_Integer myNbPointsInWline;
|
|
Standard_Real myTolOpenDomain;
|
|
Standard_Real myTolTransition;
|
|
Standard_Real myTol3D;
|
|
};
|
|
|
|
#endif // _IntPatch_ALineToWLine_HeaderFile
|