mirror of
https://git.dev.opencascade.org/repos/occt.git
synced 2025-04-03 17:56:21 +03:00
a453f9d128
Problem: From the point of view of the STEP format (and others), it is allowed to describe a face on a surface with natural boundaries (torus, sphere) without specifying these boundaries. Thus, a face on a closed surface and containing an inner wire (or several) is correctly defined and describes a face with a cutout defined by this wire. At the same time, there is a function (ShapeFix_Face::FixOrientation) in the ShapeHealing procedure that corrects the orientation of the wires, and it starts before the function of adding natural boundaries (ShapeFix_Face::FixAddNaturalBound). There are many shapes that have incorrectly oriented wires and this procedure successfully heals them, but on a correctly specified face with single inner wire on closed surface, we do not get the entire surface with a cutout, but a part of the surface defined by the wire. This fix is intended to resolve this ambiguity. Change: 1. Added function isNeedAddNaturalBound that returns TRUE if face needs to add natural bounds. 2. Corrected condition in FixOrientation to ignoring faces that needs to add natural bounds. 3. For tests in which one wire was incorrectly oriented on a closed surface, flag AddNaturalBound was disabled. 5. Test with cutout from torus was created: bugs step bug28414. Result: By default, it is correct to add natural boundaries, because this case is correct from the point of view of the STEP format and others.
57 lines
2.0 KiB
Plaintext
57 lines
2.0 KiB
Plaintext
puts "============"
|
|
puts "OCC6283"
|
|
puts "============"
|
|
puts ""
|
|
######################################################
|
|
# Unstable work fixshape on attached shape (different number of warnings)
|
|
######################################################
|
|
|
|
set BugNumber OCC6283
|
|
|
|
# Due to the ambiguous interpretation of the "inner" wire on the surfaces
|
|
# that have natural bound (is it the cutout in the whole surface, or it's just wrong wire orientation),
|
|
# we must manually turn off the adding of the natural bound option of the shape healing for this test.
|
|
if { [info exists imagedir] == 0 } {
|
|
set imagedir ../BugNumber
|
|
if {![file exists ${imagedir}]} {
|
|
file mkdir ${imagedir}
|
|
}
|
|
}
|
|
# remember the path to the old resource file
|
|
set old_resource_path $::env(CSF_STEPDefaults)
|
|
# reading old resource file
|
|
set anOptions [parse_resource_file "${old_resource_path}/STEP"]
|
|
# activation of ignoring the adding of natural bound
|
|
dict set anOptions "FromSTEP.FixShape.FixAddNaturalBoundMode" "0"
|
|
# path to new resource file
|
|
set new_resource_path ${imagedir}
|
|
# creating resource file
|
|
create_resource_file "${new_resource_path}/STEP" $anOptions
|
|
# changing the path to the resource file
|
|
set ::env(CSF_STEPDefaults) ${new_resource_path}
|
|
|
|
set list [stepread [locate_data_file wgehaeuse_surface.stp] a *]
|
|
|
|
if {[lsearch ${list} Error] > -1} {
|
|
puts "${BugNumber} : Error during reading attached STEP file"
|
|
} else {
|
|
tpcompound comp
|
|
if [catch { set fixlist [fixshape result comp 1e-7] } res] {
|
|
puts "${BugNumber}: Error during fixshape"
|
|
} else {
|
|
set index [string first "Segments were disordered; fixed\n" ${fixlist}]
|
|
if {$index != -1} {
|
|
puts "Faulty ${BugNumber}"
|
|
} else {
|
|
puts "OK ${BugNumber}"
|
|
}
|
|
checkprops result -s 2.22665e+06
|
|
checkshape result
|
|
checkview -display result -2d -path ${imagedir}/${test_image}.png
|
|
}
|
|
}
|
|
|
|
# Restoring the path to the old resource file
|
|
set ::env(CSF_STEPDefaults) ${old_resource_path}
|
|
|