OpenCascade/occt

Fork 0

mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-10 18:51:21 +03:00

Commit Graph

Author	SHA1	Message	Date
emv	1155d05a06	0025609: Clean up the duplicate classes in TKBO project 1. The package BOPCol has been fully removed: - BOPCol_BaseAllocator is replaced with Handle(NCollection_BaseAllocator); - BOPCol_BoxBndTree is replaced with BOPTools_BoxBndTree; - BOPCol_Box2DBndTree is removed as unused; - BOPCol_DataMapOfIntegerInteger is replaced with TColStd_DataMapOfIntegerInteger; - BOPCol_DataMapOfIntegerListOfInteger is replaced with TColStd_DataMapOfIntegerListOfInteger; - BOPCol_DataMapOfIntegerListOfShape is replaced with TopTools_DataMapOfIntegerListOfShape; - BOPCol_DataMapOfIntegerMapOfInteger.hxx is removed as unused; - BOPCol_DataMapOfIntegerReal is replaced with TColStd_DataMapOfIntegerReal; - BOPCol_DataMapOfIntegerShape is replaced with TopTools_DataMapOfIntegerShape; - BOPCol_DataMapOfShapeBox is replaced with TopTools_DataMapOfShapeBox; - BOPCol_DataMapOfShapeInteger is replaced with TopTools_DataMapOfShapeInteger; - BOPCol_DataMapOfShapeListOfShape is replaced with TopTools_DataMapOfShapeListOfShape; - BOPCol_DataMapOfShapeReal is replaced with TopTools_DataMapOfShapeReal; - BOPCol_DataMapOfShapeShape is replaced with TopTools_DataMapOfShapeShape; - BOPCol_DataMapOfTransientAddress is removed as unused; - BOPCol_IndexedDataMapOfIntegerListOfInteger is removed as unused; - BOPCol_IndexedDataMapOfShapeBox is removed as unused; - BOPCol_IndexedDataMapOfShapeInteger is removed as unused; - BOPCol_IndexedDataMapOfShapeListOfShape is replaced with TopTools_IndexedDataMapOfShapeListOfShape; - BOPCol_IndexedDataMapOfShapeReal is removed as unused; - BOPCol_IndexedDataMapOfShapeShape is replaced with TopTools_IndexedDataMapOfShapeShape; - BOPCol_IndexedMapOfInteger is replaced with TColStd_IndexedMapOfInteger; - BOPCol_IndexedMapOfOrientedShape is replaced with TopTools_IndexedMapOfOrientedShape; - BOPCol_IndexedMapOfShape is replaced with TopTools_IndexedMapOfShape; - BOPCol_ListOfInteger is replaced with TColStd_ListOfInteger; - BOPCol_ListOfListOfShape is replaced with TopTools_ListOfListOfShape; - BOPCol_ListOfShape is replaced with TopTools_ListOfShape; - BOPCol_MapOfInteger is replaced with TColStd_MapOfInteger; - BOPCol_MapOfOrientedShape is replaced with TopTools_MapOfOrientedShape; - BOPCol_MapOfShape is replaced with TopTools_MapOfShape; - BOPCol_PListOfInteger is removed as unused; - BOPCol_PInteger is removed as unused - BOPCol_SequenceOfPnt2d is replaced with TColgp_SequenceOfPnt2d; - BOPCol_SequenceOfReal is replaced with TColStd_SequenceOfReal; - BOPCol_SequenceOfShape is replaced with TopTools_SequenceOfShape; - BOPCol_Parallel is replaced with BOPTools_Parallel; - BOPCol_NCVector is replaced with NCollection_Vector; 2. The class BOPDS_PassKey and containers for it have been removed as unused; 3. The unused containers from IntTools package have been removed: - IntTools_DataMapOfShapeAddress is removed as unused; - IntTools_IndexedDataMapOfTransientAddress is removed as unused; 4. The container BiTgte_DataMapOfShapeBox is replaced with TopTools_DataMapOfShapeBox; 5. The class BOPTools has been removed as duplicate of the class TopExp;	2017-11-30 12:11:15 +03:00
emv	98b3765966	0029237: Improve performance of Boolean Operations In order to improve performance of Boolean Operations on the relatively fast cases the following improvements have been made: 1. Initialization of the FaceInfo information for the faces participating in Face/Face interference, even when the gluing is ON, to take into account intersection of their sub-shapes. 2. Code simplification & duplication removal - the methods BOPAlgo_ShellSplitter::MakeConnexityBlocks and BOPAlgo_WireSplitter::MakeConnexityBlocks have been unified into BOPTools_AlgoTools::MakeConnexityBlocks. 3. Avoid unnecessary bounding box computation for solids during DS initialization. The bounding boxes for solids will be computed during the building stage to find faces located inside solids. For the shape self-interference check (performed by the BOPAlgo_CheckerSI), the bounding box is still computed, as it is necessary to resolve Shape/Solid intersections. 4. Use only three sample points to check coincidence of line and plane. 5. Perform necessity of planes intersection only when the gluing is off. 6. Avoid repeated initialization of 2D classifier while building splits of the faces. 7. Post treat stage: 7.1. Method CorrectWires: Save edge's data (PCurve, parameter of the vertex, range) to avoid its recalculation. 7.2. Method CheckEdge: While checking vertices on edges avoid unnecessary calculation of their location. 8. Provide possibility to disable the classification of the input solids on the inverted status (to be the holes in the space). 9. Avoid building of bounding boxes for faces/solids during splitting of the input arguments for their classification relatively hole faces/shells if there are no holes created. 10. Avoid rebuilding of the faces/solids from arguments which does not acquire any inside parts from other arguments during the operation by using their draft versions as their splits. Test cases for the issue. Correction of the test cases boolean gdml_public A9 and bugs modalg_7 bug28485 as they are improvements. Additional test case for the issue #28485 as it is fixed by the current changes.	2017-11-01 17:27:08 +03:00
emv	33ba856502	0028786: Refactoring of the Warning/Error reporting system of Boolean Operations Algorithm 0. Basic tools for defining classes representing alerts (errors, warnings etc.) and collecting them during execution of algorithms are added in Message package. 1. Refactoring of the Error/Warning reporting system of the algorithms in Boolean Component. To dump the description of the Error/Warning status of the algorithm the DumpErrors/DumpWarnings method should be called. Also, the methods GerErrorMsg(int Error) and GetWarningMsg(int Warning) have been implemented to get the description for the given Error/Warning. All Error/Warning statuses are now listed in the enumeration ErrorStatusEnum/WarningStatusEnum of the algorithm. It is also possible to get the shapes for which the warning has been set by using the method GetWarningShapes(). 2. The new class BOPAlgo_Options has been created to unify the options of the BOPAlgo_* and BRepAlgoAPI* algorithms. 3. The new checks across the algorithms have been added to detect and report errors and warnings. 4. Test cases boolean bopcut_complex B9 E1 E5 E8 boolean bopfuse_complex B4 B5 C9 D1 D4 D5 D6 D7 have been rewritten to use Cells Builder algorithm instead of Boolean Operations algorithm, because latter always returns error "Unsupported Boolean operation" for these cases. 5. New chapter has been added in the user guide for Boolean Operations - Error / Warning reporting system. 6. Added comment to NCollection_List::Remove(Iterator&)	2017-07-06 12:41:56 +03:00

Author

SHA1

Message

Date

emv

1155d05a06

0025609: Clean up the duplicate classes in TKBO project

1. The package BOPCol has been fully removed:
- *BOPCol_BaseAllocator* is replaced with *Handle(NCollection_BaseAllocator)*;
- *BOPCol_BoxBndTree* is replaced with *BOPTools_BoxBndTree*;
- *BOPCol_Box2DBndTree* is removed as unused;
- *BOPCol_DataMapOfIntegerInteger* is replaced with *TColStd_DataMapOfIntegerInteger*;
- *BOPCol_DataMapOfIntegerListOfInteger* is replaced with *TColStd_DataMapOfIntegerListOfInteger*;
- *BOPCol_DataMapOfIntegerListOfShape* is replaced with *TopTools_DataMapOfIntegerListOfShape*;
- *BOPCol_DataMapOfIntegerMapOfInteger.hxx* is removed as unused;
- *BOPCol_DataMapOfIntegerReal* is replaced with *TColStd_DataMapOfIntegerReal*;
- *BOPCol_DataMapOfIntegerShape* is replaced with *TopTools_DataMapOfIntegerShape*;
- *BOPCol_DataMapOfShapeBox* is replaced with *TopTools_DataMapOfShapeBox*;
- *BOPCol_DataMapOfShapeInteger* is replaced with *TopTools_DataMapOfShapeInteger*;
- *BOPCol_DataMapOfShapeListOfShape* is replaced with *TopTools_DataMapOfShapeListOfShape*;
- *BOPCol_DataMapOfShapeReal* is replaced with *TopTools_DataMapOfShapeReal*;
- *BOPCol_DataMapOfShapeShape* is replaced with *TopTools_DataMapOfShapeShape*;
- *BOPCol_DataMapOfTransientAddress* is removed as unused;
- *BOPCol_IndexedDataMapOfIntegerListOfInteger* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeBox* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeInteger* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeListOfShape* is replaced with *TopTools_IndexedDataMapOfShapeListOfShape*;
- *BOPCol_IndexedDataMapOfShapeReal* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeShape* is replaced with *TopTools_IndexedDataMapOfShapeShape*;
- *BOPCol_IndexedMapOfInteger* is replaced with *TColStd_IndexedMapOfInteger*;
- *BOPCol_IndexedMapOfOrientedShape* is replaced with *TopTools_IndexedMapOfOrientedShape*;
- *BOPCol_IndexedMapOfShape* is replaced with *TopTools_IndexedMapOfShape*;
- *BOPCol_ListOfInteger* is replaced with *TColStd_ListOfInteger*;
- *BOPCol_ListOfListOfShape* is replaced with *TopTools_ListOfListOfShape*;
- *BOPCol_ListOfShape* is replaced with *TopTools_ListOfShape*;
- *BOPCol_MapOfInteger* is replaced with *TColStd_MapOfInteger*;
- *BOPCol_MapOfOrientedShape* is replaced with *TopTools_MapOfOrientedShape*;
- *BOPCol_MapOfShape* is replaced with *TopTools_MapOfShape*;
- *BOPCol_PListOfInteger* is removed as unused;
- *BOPCol_PInteger* is removed as unused
- *BOPCol_SequenceOfPnt2d* is replaced with *TColgp_SequenceOfPnt2d*;
- *BOPCol_SequenceOfReal* is replaced with *TColStd_SequenceOfReal*;
- *BOPCol_SequenceOfShape* is replaced with *TopTools_SequenceOfShape*;
- *BOPCol_Parallel* is replaced with *BOPTools_Parallel*;
- *BOPCol_NCVector* is replaced with *NCollection_Vector*;

2. The class *BOPDS_PassKey* and containers for it have been removed as unused;

3. The unused containers from *IntTools* package have been removed:
- *IntTools_DataMapOfShapeAddress* is removed as unused;
- *IntTools_IndexedDataMapOfTransientAddress* is removed as unused;

4. The container *BiTgte_DataMapOfShapeBox* is replaced with *TopTools_DataMapOfShapeBox*;

5. The class *BOPTools* has been removed as duplicate of the class *TopExp*;

2017-11-30 12:11:15 +03:00

emv

98b3765966

0029237: Improve performance of Boolean Operations

In order to improve performance of Boolean Operations on the relatively fast cases the following improvements have been made:
1. Initialization of the FaceInfo information for the faces participating in Face/Face interference, even when the gluing is ON, to take into account intersection of their sub-shapes.
2. Code simplification & duplication removal - the methods BOPAlgo_ShellSplitter::MakeConnexityBlocks and BOPAlgo_WireSplitter::MakeConnexityBlocks have been unified into BOPTools_AlgoTools::MakeConnexityBlocks.
3. Avoid unnecessary bounding box computation for solids during DS initialization. The bounding boxes for solids will be computed during the building stage to find faces located inside solids.
For the shape self-interference check (performed by the BOPAlgo_CheckerSI), the bounding box is still computed, as it is necessary to resolve Shape/Solid intersections.
4. Use only three sample points to check coincidence of line and plane.
5. Perform necessity of planes intersection only when the gluing is off.
6. Avoid repeated initialization of 2D classifier while building splits of the faces.
7. Post treat stage:
7.1. Method CorrectWires: Save edge's data (PCurve, parameter of the vertex, range) to avoid its recalculation.
7.2. Method CheckEdge: While checking vertices on edges avoid unnecessary calculation of their location.
8. Provide possibility to disable the classification of the input solids on the inverted status (to be the holes in the space).
9. Avoid building of bounding boxes for faces/solids during splitting of the input arguments for their classification relatively hole faces/shells if there are no holes created.
10. Avoid rebuilding of the faces/solids from arguments which does not acquire any inside parts from other arguments during the operation by using their draft versions as their splits.

Test cases for the issue.
Correction of the test cases boolean gdml_public A9 and bugs modalg_7 bug28485 as they are improvements.
Additional test case for the issue #28485 as it is fixed by the current changes.

2017-11-01 17:27:08 +03:00

emv

33ba856502

0028786: Refactoring of the Warning/Error reporting system of Boolean Operations Algorithm

0. Basic tools for defining classes representing alerts (errors, warnings etc.) and collecting them during execution of algorithms are added in Message package.

1. Refactoring of the Error/Warning reporting system of the algorithms in Boolean Component.
   To dump the description of the Error/Warning status of the algorithm the DumpErrors/DumpWarnings method should be called.
   Also, the methods GerErrorMsg(int Error) and GetWarningMsg(int Warning) have been implemented to get the description for the given Error/Warning.
   All Error/Warning statuses are now listed in the enumeration ErrorStatusEnum/WarningStatusEnum of the algorithm.
   It is also possible to get the shapes for which the warning has been set by using the method GetWarningShapes().

2. The new class BOPAlgo_Options has been created to unify the options of the BOPAlgo_* and BRepAlgoAPI* algorithms.

3. The new checks across the algorithms have been added to detect and report errors and warnings.

4. Test cases
  boolean bopcut_complex B9 E1 E5 E8
  boolean bopfuse_complex B4 B5 C9 D1 D4 D5 D6 D7
have been rewritten to use Cells Builder algorithm instead of Boolean Operations algorithm, because latter always returns error "Unsupported Boolean operation" for these cases.

5. New chapter has been added in the user guide for Boolean Operations - Error / Warning reporting system.

6. Added comment to NCollection_List::Remove(Iterator&)

2017-07-06 12:41:56 +03:00

3 Commits