OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0033383: Modeling Algorithms - Wire/Face creation problem

Browse Source 
ProjCurve3d and BRepAlgo_FaceRestrictor::Perform functions should not continue to work and should terminate if the BRep_Tool::Curve function returns null pointer.
This commit is contained in:
astromko 2024-02-15 14:12:39 +00:00
parent f286953d85
commit e8a36f3a02
2 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/BRepAlgo/BRepAlgo_FaceRestrictor.cxx
View File

@ -103,7 +103,7 @@ static Standard_Boolean ChangePCurve (TopoDS_Edge& E,
//purpose : //purpose :
//======================================================================= //=======================================================================
static void ProjCurve3d (TopoDS_Edge& E, static bool ProjCurve3d (TopoDS_Edge& E,
const Handle(Geom_Surface)& S, const Handle(Geom_Surface)& S,
TopLoc_Location& L) TopLoc_Location& L)
{ {
@ -111,6 +111,10 @@ static void ProjCurve3d (TopoDS_Edge& E,
TopLoc_Location LE; TopLoc_Location LE;
Standard_Real f,l; Standard_Real f,l;
Handle(Geom_Curve) C = BRep_Tool::Curve(E,LE,f,l); Handle(Geom_Curve) C = BRep_Tool::Curve(E,LE,f,l);
if (C.IsNull())
{
return false;
}
Handle(Geom_TrimmedCurve) CT = new Geom_TrimmedCurve(C,f,l); Handle(Geom_TrimmedCurve) CT = new Geom_TrimmedCurve(C,f,l);
TopLoc_Location LL = L.Inverted().Multiplied(LE); TopLoc_Location LL = L.Inverted().Multiplied(LE);
@ -118,6 +122,7 @@ static void ProjCurve3d (TopoDS_Edge& E,
Handle(Geom2d_Curve) C2 = GeomProjLib::Curve2d (CT,S); Handle(Geom2d_Curve) C2 = GeomProjLib::Curve2d (CT,S);
BB.UpdateEdge(E,C2,S,L,Precision::Confusion()); BB.UpdateEdge(E,C2,S,L,Precision::Confusion());
return true;
} }
//======================================================================= //=======================================================================
@ -165,13 +170,19 @@ void BRepAlgo_FaceRestrictor::Perform()
// no pcurve on the reference surface. // no pcurve on the reference surface.
if (modeProj) { if (modeProj) {
// Projection of the 3D curve on surface. // Projection of the 3D curve on surface.
ProjCurve3d ( E, S, L); if (!ProjCurve3d(E, S, L))
{
return;
}
} }
else { else {
// return the first pcurve glued on <S> // return the first pcurve glued on <S>
Standard_Boolean YaPCurve = ChangePCurve (E, S, L); Standard_Boolean YaPCurve = ChangePCurve (E, S, L);
if (!YaPCurve) { if (!YaPCurve) {
ProjCurve3d (E, S, L); if (!ProjCurve3d(E, S, L))
{
return;
}
} }
} }
} }

14
tests/bugs/modalg_8/bug33383 Normal file
View File

@ -0,0 +1,14 @@
puts "========================================================="
puts "0033383: Modeling Algorithms - Wire/Face creation problem"
puts "========================================================="
puts ""
pload MODELING
restore [locate_data_file bug33383.brep] a
connectedges res a 1e-07 0
explode res
mkplane pln1 res_1 1
if ![catch { buildfaces rebf pln1 res_2 }] then {
puts "Error: buildfaces command should be failed"
}