OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-04 13:13:25 +03:00
Code Activity

0032723: Draw Harness, ViewerTest - sloppy animation in WebGL

Browse Source 
Fixed emscripten_async_call() calls to use requestAnimationFrame() instead of setTimeout().
ViewerTest_EventManager::handleViewRedraw() - fixed queuing new onWasmRedrawView()
before previous one has been processed (leading to multiplying of pending redraws executed at the same time).
RWGltf_TriangulationReader::readDracoBuffer - suppressed CLang compilation warnings.
This commit is contained in:
kgv
2021-12-07 20:07:04 +03:00
committed by smoskvin
parent f4f9ce4b77
commit e3dae4a9f3
6 changed files with 44 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
samples/webgl/WasmOcctView.cpp
View File

@@ -114,7 +114,7 @@ WasmOcctView& WasmOcctView::Instance()
// ================================================================
WasmOcctView::WasmOcctView()
: myDevicePixelRatio (1.0f),
myUpdateRequests (0)
myNbUpdateRequests (0)
{
addActionHotKeys (Aspect_VKey_NavForward, Aspect_VKey_W, Aspect_VKey_W | Aspect_VKeyFlags_SHIFT);
addActionHotKeys (Aspect_VKey_NavBackward , Aspect_VKey_S, Aspect_VKey_S | Aspect_VKeyFlags_SHIFT);
@@ -395,9 +395,11 @@ void WasmOcctView::ProcessInput()
// Queue onRedrawView()/redrawView callback to redraw canvas after all user input is flushed by browser.
// Redrawing viewer on every single message would be a pointless waste of resources,
// as user will see only the last drawn frame due to WebGL implementation details.
if (++myUpdateRequests == 1)
// -1 in emscripten_async_call() redirects to requestAnimationFrame();
// requestPostAnimationFrame() is a better under development alternative.
if (++myNbUpdateRequests == 1)
{
emscripten_async_call (onRedrawView, this, 0);
emscripten_async_call (onRedrawView, this, -1);
}
}
}
@@ -424,6 +426,7 @@ void WasmOcctView::redrawView()
{
if (!myView.IsNull())
{
myNbUpdateRequests = 0;
FlushViewEvents (myContext, myView, true);
}
}
@@ -435,13 +438,14 @@ void WasmOcctView::redrawView()
void WasmOcctView::handleViewRedraw (const Handle(AIS_InteractiveContext)& theCtx,
const Handle(V3d_View)& theView)
{
myUpdateRequests = 0;
AIS_ViewController::handleViewRedraw (theCtx, theView);
if (myToAskNextFrame)
{
// ask more frames
++myUpdateRequests;
emscripten_async_call (onRedrawView, this, 0);
if (++myNbUpdateRequests == 1)
{
emscripten_async_call (onRedrawView, this, -1);
}
}
}

2
samples/webgl/WasmOcctView.h
View File

@@ -249,7 +249,7 @@ private:
TCollection_AsciiString myCanvasId; //!< canvas element id on HTML page
Graphic3d_Vec2i myWinSizeOld;
float myDevicePixelRatio; //!< device pixel ratio for handling high DPI displays
unsigned int myUpdateRequests; //!< counter for unhandled update requests
unsigned int myNbUpdateRequests; //!< counter for unhandled update requests
};