0027772: Foundation Classes - define Standard_Boolean using C++ type "bool" instead of "unsigned int"

Code has been updated to remove no-op casts and implicit casts to Standard_Boolean.

Places of inproper use of Standard_Boolean instead of Standard_Integer
have been corrected:
- Bnd_Box, Bnd_Box2d
  Bit flags are now defined as private enum
- HLRAlgo_BiPoint, HLRAlgo_EdgesBlock, HLRBRep_EdgeData, HLRBRep_FaceData
  Bit flags are now defined as enum
- HLRAlgo_EdgeStatus, HLRBRep_BiPnt2D, HLRBRep_BiPoint
  Bit flags are now defined as bool fields
- HLRAlgo_PolyData
  Bit flags are now defined as Standard_Integer
- OSD_DirectoryIterator, OSD_FileIterator
  Boolean flag is now defined as Standard_Boolean
- ShapeAnalysis_Surface::SurfaceNewton()
  now returns Standard_Integer (values 0, 1 or 3)
- ChFi2d_FilletAlgo
  now uses TColStd_SequenceOfBoolean instead of TColStd_SequenceOfInteger
  for storing boolean flags

Method IFSelect_Dispatch::PacketsCount() has been dropped from interface.

ShapeFix_Solid::Status() has been fixed to decode requested status
instead of returning integer value.

TopOpeBRepBuild_Builder1 now defines map storing Standard_Boolean values
instead of Standard_Integer.

Persistence for Standard_Boolean type has been corrected
to keep backward compatibility:
- BinMDataStd, BinTools, FSD_BinaryFile

Broken Draw Harness commands vdisplaymode and verasemode have been removed.

BRepMesh_FastDiscretFace::initDataStructure() - workaround old gcc limitations

BRepMesh_IncrementalMesh::clear() - avoid ambiguity

src/TFunction/FILES

@@ -13,7 +13,6 @@ TFunction_DriverTable.hxx
 TFunction_ExecutionStatus.hxx
 TFunction_Function.cxx
 TFunction_Function.hxx
-TFunction_Function.lxx
 TFunction_GraphNode.cxx
 TFunction_GraphNode.hxx
 TFunction_HArray1OfDataMapOfGUIDDriver.hxx

src/TFunction/TFunction_Function.hxx

@@ -63,27 +63,26 @@ public:
   Standard_EXPORT static const Standard_GUID& GetID();
   
   Standard_EXPORT TFunction_Function();
-  
+
   //! Returns the GUID for this function's driver.
-    const Standard_GUID& GetDriverGUID() const;
-  
+  const Standard_GUID& GetDriverGUID() const { return myDriverGUID; }
+
   //! Sets the driver for this function as that
   //! indentified by the GUID guid.
   Standard_EXPORT void SetDriverGUID (const Standard_GUID& guid);
-  
+
   //! Returns true if the execution failed
-    Standard_Boolean Failed() const;
-  
+  Standard_Boolean Failed() const { return myFailure != 0; }
+
   //! Sets the failed index.
   Standard_EXPORT void SetFailure (const Standard_Integer mode = 0);
-  
 
   //! Returns an index of failure if the execution of this function failed.
   //! If this integer value is 0, no failure has occurred.
   //! Implementation of Attribute methods:
   //! ===================================
-    Standard_Integer GetFailure() const;
-  
+  Standard_Integer GetFailure() const { return myFailure; }
+
   Standard_EXPORT const Standard_GUID& ID() const Standard_OVERRIDE;
   
   Standard_EXPORT virtual void Restore (const Handle(TDF_Attribute)& with) Standard_OVERRIDE;
@@ -96,30 +95,13 @@ public:
   
   Standard_EXPORT virtual Standard_OStream& Dump (Standard_OStream& anOS) const Standard_OVERRIDE;
 
-
-
-
   DEFINE_STANDARD_RTTIEXT(TFunction_Function,TDF_Attribute)
 
-protected:
-
-
-
-
 private:
 
-
   Standard_GUID myDriverGUID;
   Standard_Integer myFailure;
 
-
 };
 
-
-#include <TFunction_Function.lxx>
-
-
-
-
-
 #endif // _TFunction_Function_HeaderFile

src/TFunction/TFunction_Function.lxx

@@ -1,33 +0,0 @@
-// Created on: 1999-06-11
-// Created by: Vladislav ROMASHKO
-// Copyright (c) 1999-1999 Matra Datavision
-// Copyright (c) 1999-2014 OPEN CASCADE SAS
-//
-// This file is part of Open CASCADE Technology software library.
-//
-// This library is free software; you can redistribute it and/or modify it under
-// the terms of the GNU Lesser General Public License version 2.1 as published
-// by the Free Software Foundation, with special exception defined in the file
-// OCCT_LGPL_EXCEPTION.txt. Consult the file LICENSE_LGPL_21.txt included in OCCT
-// distribution for complete text of the license and disclaimer of any warranty.
-//
-// Alternatively, this file may be used under the terms of Open CASCADE
-// commercial license or contractual agreement.
-
-inline const Standard_GUID& TFunction_Function::GetDriverGUID() const
-{
-  return myDriverGUID;
-}
-
-inline Standard_Boolean TFunction_Function::Failed() const
-{
-  return myFailure;
-}
-
-inline Standard_Integer TFunction_Function::GetFailure() const
-{
-  return myFailure;
-}
-
-
-