0027772: Foundation Classes - define Standard_Boolean using C++ type "bool" instead of "unsigned int"

Code has been updated to remove no-op casts and implicit casts to Standard_Boolean.

Places of inproper use of Standard_Boolean instead of Standard_Integer
have been corrected:
- Bnd_Box, Bnd_Box2d
  Bit flags are now defined as private enum
- HLRAlgo_BiPoint, HLRAlgo_EdgesBlock, HLRBRep_EdgeData, HLRBRep_FaceData
  Bit flags are now defined as enum
- HLRAlgo_EdgeStatus, HLRBRep_BiPnt2D, HLRBRep_BiPoint
  Bit flags are now defined as bool fields
- HLRAlgo_PolyData
  Bit flags are now defined as Standard_Integer
- OSD_DirectoryIterator, OSD_FileIterator
  Boolean flag is now defined as Standard_Boolean
- ShapeAnalysis_Surface::SurfaceNewton()
  now returns Standard_Integer (values 0, 1 or 3)
- ChFi2d_FilletAlgo
  now uses TColStd_SequenceOfBoolean instead of TColStd_SequenceOfInteger
  for storing boolean flags

Method IFSelect_Dispatch::PacketsCount() has been dropped from interface.

ShapeFix_Solid::Status() has been fixed to decode requested status
instead of returning integer value.

TopOpeBRepBuild_Builder1 now defines map storing Standard_Boolean values
instead of Standard_Integer.

Persistence for Standard_Boolean type has been corrected
to keep backward compatibility:
- BinMDataStd, BinTools, FSD_BinaryFile

Broken Draw Harness commands vdisplaymode and verasemode have been removed.

BRepMesh_FastDiscretFace::initDataStructure() - workaround old gcc limitations

BRepMesh_IncrementalMesh::clear() - avoid ambiguity

src/Standard/Standard_Character.hxx

@@ -55,19 +55,19 @@ inline Standard_Boolean IsEqual(const Standard_Character One,
 // IsAlphabetic : Returns Standard_True if a character is alphabetic
 // ==================================================================
 inline Standard_Boolean IsAlphabetic(const Standard_Character me) 
-{ return std::isalpha ((unsigned char)me); }
+{ return std::isalpha ((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsDigit : Returns Standard_True if a character is a digit
 // ==================================================================
 inline Standard_Boolean IsDigit(const Standard_Character me) 
-{ return std::isdigit ((unsigned char)me); }
+{ return std::isdigit ((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsXDigit : Returns Standard_True if a character is a digit
 // ==================================================================
 inline Standard_Boolean IsXDigit(const Standard_Character me) 
-{ return std::isxdigit((unsigned char)me); }
+{ return std::isxdigit((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsAlphanumeric : Returns Standard_True if a character is alphanumeric
@@ -79,26 +79,26 @@ inline Standard_Boolean IsAlphanumeric(const Standard_Character me)
 // IsControl : Returns Standard_True if a character  is a control character
 // ==================================================================
 inline Standard_Boolean IsControl(const Standard_Character me) 
-{ return std::iscntrl((unsigned char)me); }
+{ return std::iscntrl((unsigned char)me) != 0; }
 
 
 // ==================================================================
 // IsGraphic : Returns Standard_True if a character is graphic
 // ==================================================================
 inline Standard_Boolean IsGraphic(const Standard_Character me) 
-{ return std::isgraph((unsigned char)me); }
+{ return std::isgraph((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsLowerCase : Returns Standard_True if a character is lowercase
 // ==================================================================
 inline Standard_Boolean IsLowerCase(const Standard_Character me) 
-{ return std::islower((unsigned char)me); }
+{ return std::islower((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsPrintable : Returns Standard_True if a character is printable
 // ==================================================================
 inline Standard_Boolean IsPrintable(const Standard_Character me) 
-{ return std::isprint((unsigned char)me); }
+{ return std::isprint((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsPunctuation : Returns Standard_True if a character is a graphic and 
@@ -111,13 +111,13 @@ inline Standard_Boolean IsPunctuation(const Standard_Character me)
 // IsSpace : Returns Standard_True if a character is a space
 // ==================================================================
 inline Standard_Boolean IsSpace(const Standard_Character me) 
-{ return std::isspace((unsigned char)me); }
+{ return std::isspace((unsigned char)me) != 0; }
 
 // ==================================================================
 // IsUppercase : Returns Standard_True if a character is uppercase
 // ==================================================================
 inline Standard_Boolean IsUpperCase(const Standard_Character me) 
-{ return std::isupper((unsigned char)me); }
+{ return std::isupper((unsigned char)me) != 0; }
 
 // ==================================================================
 // LowerCase : Returns a lowercase character

src/Standard/Standard_Transient.cxx

@@ -39,7 +39,7 @@ const Handle(Standard_Type)& Standard_Transient::DynamicType() const
 //
 Standard_Boolean Standard_Transient::IsInstance(const Handle(Standard_Type) &AType) const
 {
-  return (Standard_Boolean) (AType ==  DynamicType());
+  return (AType == DynamicType());
 }
 
 //

src/Standard/Standard_TypeDef.hxx

@@ -42,14 +42,14 @@
   #include <inttypes.h>
 #endif
 
-#define Standard_False (Standard_Boolean)0
-#define Standard_True  (Standard_Boolean)1
+#define Standard_False false
+#define Standard_True  true
 
 #include <Standard_Macro.hxx>
 
 typedef int           Standard_Integer;
 typedef double        Standard_Real;
-typedef unsigned int  Standard_Boolean;
+typedef bool          Standard_Boolean;
 typedef float         Standard_ShortReal;
 typedef char          Standard_Character;
 typedef unsigned char Standard_Byte;