0027772: Foundation Classes - define Standard_Boolean using C++ type "bool" instead of "unsigned int"

Code has been updated to remove no-op casts and implicit casts to Standard_Boolean.

Places of inproper use of Standard_Boolean instead of Standard_Integer
have been corrected:
- Bnd_Box, Bnd_Box2d
  Bit flags are now defined as private enum
- HLRAlgo_BiPoint, HLRAlgo_EdgesBlock, HLRBRep_EdgeData, HLRBRep_FaceData
  Bit flags are now defined as enum
- HLRAlgo_EdgeStatus, HLRBRep_BiPnt2D, HLRBRep_BiPoint
  Bit flags are now defined as bool fields
- HLRAlgo_PolyData
  Bit flags are now defined as Standard_Integer
- OSD_DirectoryIterator, OSD_FileIterator
  Boolean flag is now defined as Standard_Boolean
- ShapeAnalysis_Surface::SurfaceNewton()
  now returns Standard_Integer (values 0, 1 or 3)
- ChFi2d_FilletAlgo
  now uses TColStd_SequenceOfBoolean instead of TColStd_SequenceOfInteger
  for storing boolean flags

Method IFSelect_Dispatch::PacketsCount() has been dropped from interface.

ShapeFix_Solid::Status() has been fixed to decode requested status
instead of returning integer value.

TopOpeBRepBuild_Builder1 now defines map storing Standard_Boolean values
instead of Standard_Integer.

Persistence for Standard_Boolean type has been corrected
to keep backward compatibility:
- BinMDataStd, BinTools, FSD_BinaryFile

Broken Draw Harness commands vdisplaymode and verasemode have been removed.

BRepMesh_FastDiscretFace::initDataStructure() - workaround old gcc limitations

BRepMesh_IncrementalMesh::clear() - avoid ambiguity

src/OSD/OSD_DirectoryIterator.cxx

@@ -27,7 +27,7 @@
 #include <sys/stat.h>
 
 OSD_DirectoryIterator::OSD_DirectoryIterator() 
-: myFlag(0),
+: myFlag(false),
   myDescr(0),
   myEntry(0),
   myInit(0)
@@ -36,7 +36,7 @@ OSD_DirectoryIterator::OSD_DirectoryIterator()
 
 OSD_DirectoryIterator::OSD_DirectoryIterator(const OSD_Path& where,
                                              const TCollection_AsciiString& Mask)
-: myFlag(0),
+: myFlag(false),
   myDescr(0),
   myEntry(0),
   myInit(0)
@@ -74,7 +74,7 @@ Standard_Boolean OSD_DirectoryIterator::More(){
      Next();          // Now find first entry
    }
  }
- return (myFlag);
+ return myFlag;
 }
 
 // Private :  See if directory name matches with a mask (like "*.c")
@@ -102,7 +102,7 @@ int again = 1;
 struct stat stat_buf;
 char full_name[255];
 
- myFlag = 0;   // Initialize to nothing found
+ myFlag = false;   // Initialize to nothing found
 
  do{
     myEntry = readdir((DIR *)myDescr);

src/OSD/OSD_DirectoryIterator.hxx

@@ -86,7 +86,7 @@ public:
 
 private:
   OSD_Directory TheIterator;
-  Standard_Integer myFlag;
+  Standard_Boolean myFlag;
   TCollection_AsciiString myMask;
   TCollection_AsciiString myPlace;
   OSD_Error myError;

src/OSD/OSD_FileIterator.cxx

@@ -51,7 +51,7 @@ extern char *vmsify PARAMS ((char *name, int type));
 
 
 OSD_FileIterator::OSD_FileIterator()
-: myFlag(0),
+: myFlag(false),
   myDescr(0),
   myEntry(0),
   myInit(0)
@@ -60,7 +60,7 @@ OSD_FileIterator::OSD_FileIterator()
 
 OSD_FileIterator::OSD_FileIterator(const OSD_Path& where,
                                    const TCollection_AsciiString& Mask)
-: myFlag(0),
+: myFlag(false),
   myDescr(0),
   myEntry(0),
   myInit(0)
@@ -96,7 +96,7 @@ Standard_Boolean OSD_FileIterator::More(){
      Next();          // Now find first entry
    }
  }
- return (myFlag);
+ return myFlag;
 }
 
 // Private :  See if file name matches with a mask (like "*.c")
@@ -178,7 +178,7 @@ int again = 1;
 struct stat stat_buf;
 char full_name[255];
 
- myFlag = 0;   // Initialize to nothing found
+ myFlag = false;   // Initialize to nothing found
 
  do {
     myEntry = readdir((DIR *)myDescr);

src/OSD/OSD_FileIterator.hxx

@@ -78,7 +78,7 @@ public:
 private:
 
   OSD_File TheIterator;
-  Standard_Integer myFlag;
+  Standard_Boolean myFlag;
   TCollection_AsciiString myMask;
   TCollection_AsciiString myPlace;
   OSD_Error myError;