OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0023903: Invalid result of pipe operation on closed path

Browse Source 
Add test case for this fix
This commit is contained in:
skv 2013-05-16 11:35:11 +04:00
parent 244587f413
commit cf3327f417
3 changed files with 155 additions and 139 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/BRepFill/BRepFill_Pipe.cxx
View File

@ -849,15 +849,9 @@ TopoDS_Shape BRepFill_Pipe::ShareFaces
anExp.Init(myFaces->Value(ii, jj), TopAbs_EDGE); anExp.Init(myFaces->Value(ii, jj), TopAbs_EDGE);
for (; anExp.More(); anExp.Next()) { for (; anExp.More(); anExp.Next()) {
if (aMapBndEdgeIndex.IsBound(anExp.Current())) {
// This is not boundary edge. Remove it.
aMapBndEdgeIndex.UnBind(anExp.Current());
} else {
// Add boundary edge.
aMapBndEdgeIndex.Bind(anExp.Current(), ii); aMapBndEdgeIndex.Bind(anExp.Current(), ii);
} }
} }
}
// Check if edges of newly created faces are shared with old ones. // Check if edges of newly created faces are shared with old ones.
for (ii = theInitialFacesLen + 1; ii <= myFaces->ColLength(); ii++) { for (ii = theInitialFacesLen + 1; ii <= myFaces->ColLength(); ii++) {

2
src/BRepFill/BRepFill_Sweep.cxx
View File

@ -2065,7 +2065,6 @@ BRepFill_Sweep::BRepFill_Sweep(const Handle(BRepFill_SectionLaw)& Section,
Standard_Boolean exuv, singu, singv; Standard_Boolean exuv, singu, singv;
Handle(Geom_Surface) S; Handle(Geom_Surface) S;
if (! vclose) {
// (2.0) return preexisting Edges and vertices // (2.0) return preexisting Edges and vertices
TopoDS_Edge E; TopoDS_Edge E;
if (! FirstShape.IsNull() && (IFirst==1)) { if (! FirstShape.IsNull() && (IFirst==1)) {
@ -2203,7 +2202,6 @@ BRepFill_Sweep::BRepFill_Sweep(const Handle(BRepFill_SectionLaw)& Section,
mySec->VertexTol(isec-1, Vi(NbPath+1))); mySec->VertexTol(isec-1, Vi(NbPath+1)));
} }
} }
}
// ---------- Creation of Vertex and edge ------------ // ---------- Creation of Vertex and edge ------------

24
tests/bugs/modalg_5/bug23903 Executable file
View File

@ -0,0 +1,24 @@
puts "============"
puts "OCC23903"
puts "============"
puts ""
#######################################################################
# Invalid result of pipe operation on closed path
#######################################################################
restore [locate_data_file bug23903_base.brep] sh
restore [locate_data_file bug23903_path.brep] w
pipe result w sh
set nb_v_good 2
set nb_e_good 5
set nb_w_good 3
set nb_f_good 3
set nb_sh_good 2
set nb_sol_good 2
set nb_compsol_good 0
set nb_compound_good 1
set nb_shape_good 18
set 2dviewer 1