OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0029845: UnifySameDomain does not account the accumulated angle when unifying edges

Browse Source 
Check that the accumulated angle does not exceed the given angular tolerance while merging the linear edges.
Test case for the issue.
This commit is contained in:
emv 2018-06-07 08:29:21 +03:00 committed by bugmaster
parent 0c44027cb9
commit cf12784f94
2 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
View File

@ -849,12 +849,20 @@ static Standard_Boolean IsMergingPossible(const TopoDS_Edge& edge1, const TopoDS
if (theLineDirectionOk && t2 == GeomAbs_Line) if (theLineDirectionOk && t2 == GeomAbs_Line)
{ {
// Check that the accumulated deflection does not exceed the linear tolerance
Standard_Real aLast = (edge2.Orientation() == TopAbs_FORWARD) ? Standard_Real aLast = (edge2.Orientation() == TopAbs_FORWARD) ?
ade2.LastParameter() : ade2.FirstParameter(); ade2.LastParameter() : ade2.FirstParameter();
gp_Vec aCurV(theFirstPoint, ade2.Value(aLast)); gp_Vec aCurV(theFirstPoint, ade2.Value(aLast));
Standard_Real aDD = theDirectionVec.CrossSquareMagnitude(aCurV); Standard_Real aDD = theDirectionVec.CrossSquareMagnitude(aCurV);
if (aDD > theLinTol*theLinTol) if (aDD > theLinTol*theLinTol)
return Standard_False; return Standard_False;
// Check that the accumulated angle does not exceed the angular tolerance.
// For symmetry, check the angle between vectors of:
// - first edge and resulting curve, and
// - the last edge and resulting curve.
if (theDirectionVec.Angle(aCurV) > theAngTol || Diff2.Angle(aCurV) > theAngTol)
return Standard_False;
} }
return Standard_True; return Standard_True;

21
tests/bugs/modalg_7/bug29845 Normal file
View File

@ -0,0 +1,21 @@
puts "========"
puts "OCC29845:UnifySameDomain does not account the accumulated angle when unifying edges"
puts "========"
puts ""
brestore [locate_data_file bug29845_wire.brep] w
# set the linear deflection very high, so the unification
# will be controlled by the angular deflection only.
# with the angular deflection of 5 degrees the resulting
# wire should preserve all the features of the original wire
unifysamedom result w -t 10000 -a 5
checkshape result
checknbshapes result -vertex 77 -edge 77
checkprops result -l 2805.11
smallview +X+Z
don result
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png