OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0026568: Modeling Algorithms - Exception when creating pipe

Browse Source 
BRepFill_Pipe.cxx:  protection against wrong shape type is added
GeomFill_Sweep.cxx:  protection against using 0-vector to create Direction is added

bug26568: test script is corrected: "TODO ..." is removed
This commit is contained in:
ifv 2020-08-11 17:00:03 +03:00 committed by bugmaster
parent f3269ef5f1
commit ce9aefc8aa
3 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/BRepFill/BRepFill_Pipe.cxx
View File

@ -760,8 +760,11 @@ TopoDS_Shape BRepFill_Pipe::MakeShape(const TopoDS_Shape& S,
TopoDS_Face F;
for (ii=InitialLength+1; ii<=myFaces->ColLength(); ii++) {
for (jj=1; jj<=myFaces->RowLength(); jj++) {
F = TopoDS::Face(myFaces->Value(ii, jj));
if (!F.IsNull()) B.Add(result, F);
if (myFaces->Value(ii, jj).ShapeType() == TopAbs_FACE)
{
F = TopoDS::Face(myFaces->Value(ii, jj));
if (!F.IsNull()) B.Add(result, F);
}
}
}

7
src/GeomFill/GeomFill_Sweep.cxx
View File

@ -953,7 +953,12 @@ static Standard_Boolean IsSweepParallelSpine (const Handle(GeomFill_LocationLaw)
// (2.2.a) Cylindre
// si la line est orthogonale au plan de rotation
SError = error;
gp_Ax3 Axis(CentreOfSurf, Dir.Direction(), DS);
//
gp_Ax3 Axis(CentreOfSurf, Dir.Direction());
if (DS.SquareMagnitude() > gp::Resolution())
{
Axis.SetXDirection(DS);
}
S = new (Geom_CylindricalSurface)
(Axis, L.Distance(CentreOfSurf));
Ok = Standard_True;

22
tests/bugs/modalg_7/bug26568
View File

@ -1,10 +1,6 @@
puts "TODO OCC26568 ALL: An exception was caught"
puts "TODO OCC26568 ALL: \\*\\* Exception \\*\\*.*"
puts "TODO OCC26568 ALL: TEST INCOMPLETE"
puts "========"
puts "OCC26568"
puts "========"
puts "============================================================="
puts "OCC26568 - Modeling Algorithms - Crash when creating pipe"
puts "============================================================="
puts ""
################################
# Exception when creating pipe
@ -15,4 +11,14 @@ explode b f
circle c 0 0 0 0 1 0 10
mkedge e c
wire w e
pipe p w b_1
pipe result w b_1
checkshape result
checknbshapes result -solid 1 -shell 1 -face 3 -wire 3 -edge 7 -vertex 4
set tolres [checkmaxtol result]
if { ${tolres} > 2.e-7} {
puts "Error: bad tolerance of result"
}