OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-06 18:26:22 +03:00
Code Packages Releases Activity

0033306: Modeling Algorithm - Crash in TrimEdge() method

Browse Source 
Added condition to not cut the edges by closely located parameters
This commit is contained in:
akaftasev 2023-01-04 14:47:00 +03:00 committed by Vadim Glukhikh
parent 9f338a00a1
commit ce4d294074
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/BRepFill/BRepFill_CompatibleWires.cxx
View File

@ -351,6 +351,10 @@ static void TrimEdge (const TopoDS_Edge& CurrentEdge,
for (j=1; j<=ndec; j++) { for (j=1; j<=ndec; j++) {
// piece of edge // piece of edge
m1 = (CutValues.Value(j)-t0)*(last-first)/(t1-t0)+first; m1 = (CutValues.Value(j)-t0)*(last-first)/(t1-t0)+first;
if (Abs(m0 - m1) < Precision::Confusion())
{
return;
}
TopoDS_Edge CutE = BRepLib_MakeEdge(C,V0,Vbid,m0,m1); TopoDS_Edge CutE = BRepLib_MakeEdge(C,V0,Vbid,m0,m1);
CutE.Orientation(CurrentOrient); CutE.Orientation(CurrentOrient);
S.Append(CutE); S.Append(CutE);
@ -358,6 +362,10 @@ static void TrimEdge (const TopoDS_Edge& CurrentEdge,
V0 = TopExp::LastVertex(CutE); V0 = TopExp::LastVertex(CutE);
if (j==ndec) { if (j==ndec) {
// last piece // last piece
if (Abs(m0 - last) < Precision::Confusion())
{
return;
}
TopoDS_Edge LastE = BRepLib_MakeEdge(C,V0,Vl,m0,last); TopoDS_Edge LastE = BRepLib_MakeEdge(C,V0,Vl,m0,last);
LastE.Orientation(CurrentOrient); LastE.Orientation(CurrentOrient);
S.Append(LastE); S.Append(LastE);
@ -371,6 +379,10 @@ static void TrimEdge (const TopoDS_Edge& CurrentEdge,
for (j=ndec; j>=1; j--) { for (j=ndec; j>=1; j--) {
// piece of edge // piece of edge
m0 = (CutValues.Value(j)-t0)*(last-first)/(t1-t0)+first; m0 = (CutValues.Value(j)-t0)*(last-first)/(t1-t0)+first;
if (Abs(m0 - m1) < Precision::Confusion())
{
return;
}
TopoDS_Edge CutE = BRepLib_MakeEdge(C,Vbid,V1,m0,m1); TopoDS_Edge CutE = BRepLib_MakeEdge(C,Vbid,V1,m0,m1);
CutE.Orientation(CurrentOrient); CutE.Orientation(CurrentOrient);
S.Append(CutE); S.Append(CutE);
@ -378,6 +390,10 @@ static void TrimEdge (const TopoDS_Edge& CurrentEdge,
V1 = TopExp::FirstVertex(CutE); V1 = TopExp::FirstVertex(CutE);
if (j==1) { if (j==1) {
// last piece // last piece
if (Abs(first - m1) < Precision::Confusion())
{
return;
}
TopoDS_Edge LastE = BRepLib_MakeEdge(C,Vf,V1,first,m1); TopoDS_Edge LastE = BRepLib_MakeEdge(C,Vf,V1,first,m1);
LastE.Orientation(CurrentOrient); LastE.Orientation(CurrentOrient);
S.Append(LastE); S.Append(LastE);
@ -547,6 +563,10 @@ static Standard_Boolean EdgeIntersectOnWire (const gp_Pnt& P1,
SR.Clear(); SR.Clear();
SR.Append(param); SR.Append(param);
TrimEdge(E,SR,first,last,SO,SE); TrimEdge(E,SR,first,last,SO,SE);
if (SE.IsEmpty())
{
return Standard_False;
}
theEdgeNewEdges(E) = SE; theEdgeNewEdges(E) = SE;
TopoDS_Vertex VV1,VV2; TopoDS_Vertex VV1,VV2;
TopExp::Vertices(TopoDS::Edge(SE.Value(1)),VV1,VV2); TopExp::Vertices(TopoDS::Edge(SE.Value(1)),VV1,VV2);

11
tests/bugs/modalg_8/bug33306 Normal file
View File

@ -0,0 +1,11 @@
puts "REQUIRED ALL: Algorithm has failed"
puts "========================"
puts "0033306: Modeling Algorithm - Crash in TrimEdge() method"
puts "========================"
puts ""
restore [locate_data_file bug33306_1.brep] w1
restore [locate_data_file bug33306_2.brep] w2
thrusections res 0 0 w1 w2