OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0033304: Modeling Data - Floating point signal when converting a B-spline curve to analytical form

Browse Source 
Protect the static function ConicDefinition from calling sqrt with negative argument.
This commit is contained in:
msv 2022-12-27 22:19:11 +03:00 committed by vglukhik
parent d462aae370
commit cbf6b87074
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/GeomConvert/GeomConvert_CurveToAnaCurve.cxx
View File

@ -429,6 +429,8 @@ static Standard_Boolean ConicDefinition
term2 = -gdet/(cprim*pdet); term2 = -gdet/(cprim*pdet);
if (IsEllip) { if (IsEllip) {
if (term1 <= eps || term2 <= eps)
return Standard_False;
Xax = cost; Xax = cost;
Yax = sint; Yax = sint;
Rmin = sqrt ( term1); Rmin = sqrt ( term1);
@ -439,12 +441,16 @@ static Standard_Boolean ConicDefinition
} }
} }
else if (term1 <= eps){ else if (term1 <= eps){
if (-term1 <= eps || term2 <= eps)
return Standard_False;
Xax = -sint; Xax = -sint;
Yax = cost; Yax = cost;
Rmin = sqrt (-term1); Rmin = sqrt (-term1);
Rmax = sqrt (term2); Rmax = sqrt (term2);
} }
else { else {
if (term1 <= eps || -term2 <= eps)
return Standard_False;
Xax = cost; Xax = cost;
Yax = sint; Yax = sint;
Rmin = sqrt (-term2); Rmin = sqrt (-term2);

9
tests/bugs/moddata_3/bug33304 Normal file
View File

@ -0,0 +1,9 @@
puts "==========================================================="
puts "0033304: Modeling Data - Floating point signal when converting a B-spline curve to analytical form"
puts "==========================================================="
puts "REQUIRED ALL: Conversion failed"
binrestore [locate_data_file bug33304_bspl_curv.bbrep] a
mkcurve c a
tocanon r c