OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-16 10:08:36 +03:00
Code

0024385: Shape fix shape does not correct closed flag for shell

Browse Source 
Modified test cases de/step_4/C9 and de/step_4/D1 regarding to new reference data
This commit is contained in:
pdn 2013-11-28 10:45:18 +04:00 committed by bugmaster
parent 941a7a240c
commit c4edd925fd
3 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ShapeFix/ShapeFix_Shell.cxx
View File

@ -871,12 +871,19 @@ Standard_Boolean ShapeFix_Shell::FixFaceOrientation(const TopoDS_Shell& shell,co
TopTools_IndexedDataMapOfShapeListOfShape aMapEdgeFaces; TopTools_IndexedDataMapOfShapeListOfShape aMapEdgeFaces;
TopExp::MapShapesAndAncestors(myShell,TopAbs_EDGE,TopAbs_FACE,aMapEdgeFaces); TopExp::MapShapesAndAncestors(myShell,TopAbs_EDGE,TopAbs_FACE,aMapEdgeFaces);
TopTools_MapOfShape aMapMultiConnectEdges; TopTools_MapOfShape aMapMultiConnectEdges;
if(isAccountMultiConex) { Standard_Boolean isFreeBoundaries = Standard_False;
//Finds multishared edges
for(Standard_Integer k = 1; k <= aMapEdgeFaces.Extent(); k++) { for(Standard_Integer k = 1; k <= aMapEdgeFaces.Extent(); k++) {
if(aMapEdgeFaces.FindFromIndex(k).Extent() >2) Standard_Integer aFaceCount = aMapEdgeFaces.FindFromIndex(k).Extent();
//Finds multishared edges
if (isAccountMultiConex && aFaceCount > 2)
aMapMultiConnectEdges.Add(aMapEdgeFaces.FindKey(k)); aMapMultiConnectEdges.Add(aMapEdgeFaces.FindKey(k));
if (aFaceCount == 1)
isFreeBoundaries = Standard_True;
} }
if (BRep_Tool::IsClosed (myShell) == isFreeBoundaries)
{
myShell.Closed (!isFreeBoundaries);
SendWarning (Message_Msg ("FixAdvShell.FixClosedFlag.MSG0"));//Shell has incorrect flag isClosed
} }
Standard_Boolean isGetShells = Standard_True; Standard_Boolean isGetShells = Standard_True;
//Gets possible shells with taking in account of multiconnexity. //Gets possible shells with taking in account of multiconnexity.

5
tests/de/step_4/C9
View File

@ -1,9 +1,12 @@
# !!!! This file is generated automatically, do not edit manually! See end script # !!!! This file is generated automatically, do not edit manually! See end script
puts "TODO CR23096 ALL: TPSTAT : Faulty"
set filename db_exhaust-A.stp set filename db_exhaust-A.stp
set ref_data { set ref_data {
DATA : Faulties = 0 ( 0 ) Warnings = 0 ( 0 ) Summary = 0 ( 0 ) DATA : Faulties = 0 ( 0 ) Warnings = 0 ( 0 ) Summary = 0 ( 0 )
TPSTAT : Faulties = 0 ( 0 ) Warnings = 6 ( 6 ) Summary = 6 ( 6 ) TPSTAT : Faulties = 0 ( 0 ) Warnings = 7 ( 6 ) Summary = 7 ( 6 )
CHECKSHAPE : Wires = 0 ( 0 ) Faces = 0 ( 0 ) Shells = 0 ( 0 ) Solids = 0 ( 0 ) CHECKSHAPE : Wires = 0 ( 0 ) Faces = 0 ( 0 ) Shells = 0 ( 0 ) Solids = 0 ( 0 )
NBSHAPES : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) Summary = 617 ( 612 ) NBSHAPES : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) Summary = 617 ( 612 )
STATSHAPE : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) FreeWire = 0 ( 0 ) FreeEdge = 0 ( 0 ) SharedEdge = 280 ( 275 ) STATSHAPE : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) FreeWire = 0 ( 0 ) FreeEdge = 0 ( 0 ) SharedEdge = 280 ( 275 )

5
tests/de/step_4/D1
View File

@ -1,9 +1,12 @@
# !!!! This file is generated automatically, do not edit manually! See end script # !!!! This file is generated automatically, do not edit manually! See end script
puts "TODO CR23096 ALL: TPSTAT : Faulty"
set filename db_exhaust-B.stp set filename db_exhaust-B.stp
set ref_data { set ref_data {
DATA : Faulties = 0 ( 0 ) Warnings = 0 ( 0 ) Summary = 0 ( 0 ) DATA : Faulties = 0 ( 0 ) Warnings = 0 ( 0 ) Summary = 0 ( 0 )
TPSTAT : Faulties = 0 ( 0 ) Warnings = 6 ( 6 ) Summary = 6 ( 6 ) TPSTAT : Faulties = 0 ( 0 ) Warnings = 7 ( 6 ) Summary = 7 ( 6 )
CHECKSHAPE : Wires = 0 ( 0 ) Faces = 0 ( 0 ) Shells = 0 ( 0 ) Solids = 0 ( 0 ) CHECKSHAPE : Wires = 0 ( 0 ) Faces = 0 ( 0 ) Shells = 0 ( 0 ) Solids = 0 ( 0 )
NBSHAPES : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) Summary = 617 ( 612 ) NBSHAPES : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) Summary = 617 ( 612 )
STATSHAPE : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) FreeWire = 0 ( 0 ) FreeEdge = 0 ( 0 ) SharedEdge = 280 ( 275 ) STATSHAPE : Solid = 3 ( 3 ) Shell = 3 ( 3 ) Face = 41 ( 41 ) FreeWire = 0 ( 0 ) FreeEdge = 0 ( 0 ) SharedEdge = 280 ( 275 )