OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0027222: Empty result of making volume operation

Browse Source 
1. BOPAlgo_MakerVolume - Taking into account the possibility of Same Domain faces
   while collecting the faces for building the solids;
2. BOPDS_DS - Making the check on coincidence of edges consistent with the intersection
   algorithm which also adds the Precision::Confusion() to the intersection tolerance;
3. Test case for the issue.
4. Adjusting test cases (improvements) to their new behavior.
This commit is contained in:
emv 2016-08-30 08:36:48 +03:00 committed by bugmaster
parent 02974a19c6
commit c45fefa76e
7 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/BOPAlgo/BOPAlgo_MakerVolume.cxx
View File

@ -200,6 +200,7 @@ void BOPAlgo_MakerVolume::CollectFaces()
// //
Standard_Integer i, aNbShapes; Standard_Integer i, aNbShapes;
BOPCol_ListIteratorOfListOfShape aIt; BOPCol_ListIteratorOfListOfShape aIt;
BOPCol_MapOfShape aMFence;
// //
aNbShapes = myDS->NbSourceShapes(); aNbShapes = myDS->NbSourceShapes();
for (i = 0; i < aNbShapes; ++i) { for (i = 0; i < aNbShapes; ++i) {
@ -217,7 +218,9 @@ void BOPAlgo_MakerVolume::CollectFaces()
aIt.Initialize(aLFIm); aIt.Initialize(aLFIm);
for (; aIt.More(); aIt.Next()) { for (; aIt.More(); aIt.Next()) {
const TopoDS_Shape& aFIm = aIt.Value(); const TopoDS_Shape& aFIm = aIt.Value();
AddFace(aFIm, myFaces); if (aMFence.Add(aFIm)) {
AddFace(aFIm, myFaces);
}
} }
} }
else { else {

2
src/BOPDS/BOPDS_DS.cxx
View File

@ -1734,7 +1734,7 @@ Standard_Boolean BOPDS_DS::CheckCoincidence
aD=aPPC.LowerDistance(); aD=aPPC.LowerDistance();
// //
aTol=BRep_Tool::Tolerance(aE1); aTol=BRep_Tool::Tolerance(aE1);
aTol=aTol+BRep_Tool::Tolerance(aE2); aTol=aTol+BRep_Tool::Tolerance(aE2) + Precision::Confusion();
if (aD<aTol) { if (aD<aTol) {
aT2x=aPPC.LowerDistanceParameter(); aT2x=aPPC.LowerDistanceParameter();
if (aT2x>aT21 && aT2x<aT22) { if (aT2x>aT21 && aT2x<aT22) {

6
tests/boolean/volumemaker/A3
View File

@ -1,10 +1,6 @@
# test script on make volume operation # test script on make volume operation
# plane unstable # plane unstable
puts "TODO OCC26020 ALL: Error: bopcheck failed"
puts "TODO ?OCC26020 ALL: Faulty shapes in variables faulty_1"
puts "TODO OCC26020 ALL: Error : The area of result shape is"
# planar face # planar face
plane pln_f1 0 -870 -1.3877787807814457e-014 0 1 1.1102230246251565e-016 plane pln_f1 0 -870 -1.3877787807814457e-014 0 1 1.1102230246251565e-016
erase pln_f1 erase pln_f1
@ -38,5 +34,5 @@ mkface f6 pln_f6 -1000000 1000000 -1000000 1000000
# make volume operation # make volume operation
mkvolume result f1 f2 f3 f4 f5 f6 mkvolume result f1 f2 f3 f4 f5 f6
checkprops result -s 1183220. checkprops result -s 1.00062e+006

3
tests/boolean/volumemaker/A7
View File

@ -1,9 +1,6 @@
# test script on make volume operation # test script on make volume operation
# plane unstable # plane unstable
puts "TODO OCC26020 ALL: Error: bopcheck failed"
puts "TODO OCC26020 ALL: Faulty shapes in variables faulty_1 to"
# planar face # planar face
plane pln_f1 -1863.18155559 1250 -1538.57262704 1.110223024625157e-016 1 1.1102230246251563e-016 plane pln_f1 -1863.18155559 1250 -1538.57262704 1.110223024625157e-016 1 1.1102230246251563e-016
erase pln_f1 erase pln_f1

3
tests/boolean/volumemaker/B6
View File

@ -1,6 +1,3 @@
puts "TODO OCC26020 ALL: Faulty shapes in variables faulty_1 to faulty_"
puts "TODO OCC26020 ALL: Error: bopcheck failed"
# test script on make volume operation # test script on make volume operation
# plane # plane

3
tests/boolean/volumemaker/C2
View File

@ -1,9 +1,6 @@
# test script on make volume operation # test script on make volume operation
# plane # plane
puts "TODO ?OCC26020 ALL: Faulty shapes in variables faulty_1 to faulty_"
puts "TODO OCC26020 ALL: Error: bopcheck failed"
# planar face # planar face
plane pln_f1 0 840 1.2212453270876722e-014 0 -1 -1.1102230246251565e-016 plane pln_f1 0 840 1.2212453270876722e-014 0 -1 -1.1102230246251565e-016
erase pln_f1 erase pln_f1

13
tests/bugs/modalg_6/bug27222 Normal file
View File

@ -0,0 +1,13 @@
puts "============"
puts "OCC27222"
puts "============"
puts ""
######################################################
# Empty result of making volume operation
######################################################
restore [locate_data_file bug27222.brep] cf
mkvolume result cf -c
checkprops result -s 838000 -v 3.5068e+007
checknbshapes result -solid 1