OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0030835: Possible performance improvements in methods TDF_Label::FindAttribute

Browse Source 
Make attribute iterator work with pointers to attributes, so, creation of handle on each iteration is avoided.
This commit is contained in:
mpv 2019-07-29 17:11:54 +03:00 committed by bugmaster
parent 607e5e62e7
commit c2100640f6
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/TDF/TDF_AttributeIterator.hxx
View File

@ -61,6 +61,9 @@ public:
Standard_EXPORT void Next() ; Standard_EXPORT void Next() ;
inline Handle(TDF_Attribute) Value() const; inline Handle(TDF_Attribute) Value() const;
//! Provides an access to the internal pointer of the current attribute.
//! The method has better performance as not-creating handle.
inline const TDF_Attribute* PtrValue() const { return myValue; }
protected: protected:

4
src/TDF/TDF_Label.cxx
View File

@ -60,8 +60,8 @@ Standard_Boolean TDF_Label::FindAttribute
if (IsNull()) throw Standard_NullObject("A null Label has no attribute."); if (IsNull()) throw Standard_NullObject("A null Label has no attribute.");
TDF_AttributeIterator itr (myLabelNode); // Without removed attributes. TDF_AttributeIterator itr (myLabelNode); // Without removed attributes.
for ( ; itr.More(); itr.Next()) { for ( ; itr.More(); itr.Next()) {
if (itr.Value()->ID() == anID) { if (itr.PtrValue()->ID() == anID) {
anAttribute = itr.Value(); anAttribute = itr.PtrValue();
return Standard_True; return Standard_True;
} }
} }

2
src/TDF/TDF_Label.hxx
View File

@ -154,7 +154,7 @@ public:
template <class T> template <class T>
Standard_Boolean FindAttribute (const Standard_GUID& theID, Handle(T)& theAttr) const Standard_Boolean FindAttribute (const Standard_GUID& theID, Handle(T)& theAttr) const
{ {
Handle(TDF_Attribute) anAttr = theAttr; Handle(TDF_Attribute) anAttr;
return FindAttribute (theID, anAttr) && ! (theAttr = Handle(T)::DownCast(anAttr)).IsNull(); return FindAttribute (theID, anAttr) && ! (theAttr = Handle(T)::DownCast(anAttr)).IsNull();
} }