OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0033591: Modeling Algorithms - Regression: old surface is not removed after translation or rotation with geometry copying

Browse Source 
In order to avoid the problem we should always perform the commands in the "if (IsNewCur)" block after NewCurve() function even if NewCurve() returns a null-curve.
Added additional condition for this purpose..
This commit is contained in:
astromko 2024-04-01 13:34:16 +00:00 committed by jfa
parent 1e5dd88f50
commit bb43d0cc19
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/BRepTools/BRepTools_Modifier.cxx
View File

@ -630,7 +630,7 @@ void BRepTools_Modifier::FillNewCurveInfo(const TopTools_IndexedDataMapOfShapeLi
{
const TopoDS_Edge& anE = TopoDS::Edge(theMEF.FindKey(i));
Standard_Boolean IsNewCur = M->NewCurve(anE, aCurve, aLocation, aToler);
if (IsNewCur)
if (IsNewCur || M->IsKind("BRepTools_TrsfModification"))
{
aNCinfo.myCurve = aCurve;
aNCinfo.myLoc = aLocation;

29
tests/bugs/modalg_8/bug33591 Normal file
View File

@ -0,0 +1,29 @@
puts "========================"
puts "0033591: Modeling Algorithms - Regression: old surface is not removed after translation or rotation with geometry copying"
puts "========================"
puts ""
pload MODELING
pcylinder Cylinder_1 80 200
pcylinder Cylinder_2 60 200
psphere Sphere_1 80
psphere Sphere_2 60
trotate Sphere_1 0 0 0 0 1 0 90 -copy
trotate Sphere_2 0 0 0 0 1 0 90 -copy
ttranslate Sphere_1 0 0 200 -copy
ttranslate Sphere_2 0 0 200 -copy
bfuse Fuse_1 Sphere_1 Cylinder_1
bfuse Fuse_2 Cylinder_2 Sphere_2
bclear
baddobjects Fuse_1 Fuse_2
bfillds
bbuild Partition_1
explode Partition_1
plane pln_1 0 0 200
mkface Plane_1 pln_1 -100 100 -100 100
bclear
baddobjects Partition_1_2
baddtools Plane_1
bfillds
bbuild res
checkshape res