OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0029159: Sewing fail when using a maximum tolerance

Browse Source 
Force setting truly computed tolerance of the edge if BRepLib::SameParameter has put too large tolerance.
This commit is contained in:
msv 2017-09-29 10:43:52 +03:00 committed by bugmaster
parent da2a6aee19
commit b92bc5ab7c
2 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/BRepBuilderAPI/BRepBuilderAPI_Sewing.cxx
View File

@ -51,6 +51,7 @@
#include <BRep_ListOfPointRepresentation.hxx> #include <BRep_ListOfPointRepresentation.hxx>
#include <BRep_PointOnCurve.hxx> #include <BRep_PointOnCurve.hxx>
#include <BRep_Tool.hxx> #include <BRep_Tool.hxx>
#include <BRep_TEdge.hxx>
#include <BRep_TVertex.hxx> #include <BRep_TVertex.hxx>
#include <BRepBuilderAPI_BndBoxTreeSelector.hxx> #include <BRepBuilderAPI_BndBoxTreeSelector.hxx>
#include <BRepBuilderAPI_CellFilter.hxx> #include <BRepBuilderAPI_CellFilter.hxx>
@ -961,11 +962,22 @@ TopoDS_Edge BRepBuilderAPI_Sewing::SameParameterEdge(const TopoDS_Edge& edgeFirs
if (dist > dist2) if (dist > dist2)
dist2 = dist; dist2 = dist;
} }
maxTol = Max(sqrt(dist2), Precision::Confusion()); maxTol = Max(sqrt(dist2) * (1. + 1e-7), Precision::Confusion());
}
}
if (maxTol >= 0. && maxTol < tolReached)
{
if (tolReached > MaxTolerance())
{
// Set tolerance directly to overwrite too large tolerance
static_cast<BRep_TEdge*>(edge.TShape().get())->Tolerance(maxTol);
}
else
{
// just update tolerance with computed distance
aBuilder.UpdateEdge(edge, maxTol);
} }
} }
if(maxTol >= 0. && maxTol < tolReached)
aBuilder.UpdateEdge(edge, maxTol);
aBuilder.SameParameter(edge,Standard_True); aBuilder.SameParameter(edge,Standard_True);
} }
} }

31
tests/bugs/modalg_7/bug29159 Normal file
View File

@ -0,0 +1,31 @@
puts "========"
puts "OCC29159"
puts "========"
puts ""
#################################################
# Sewing fail when using a maximum tolerance
#################################################
set MaxTol 5e-4
set ExpLength 97.234
restore [locate_data_file bug29159_F.brep] f
sewing result 5e-4 f +mint 1e-8 +maxt $MaxTol
regexp {EDGE *: MAX=([-0-9.+eE]+)} [tolerance result] full toler
if {$toler > $MaxTol} {
puts "Error: Tolerance after sewing is greater than max allowed tolerance"
}
if {[regexp "self-interfering" [bopcheck result 2]]} {
puts "Error: result of sewing is self-interfering"
}
checknbshapes result -m "Sewing result" -edge 8 -face 2
checkprops result -l $ExpLength -skip
smallview +X+Y
don result
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}_1.png