OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0026377: Passing Handle objects as arguments to functions as non-const reference to base type is dangerous

Browse Source 
Operator of cast to non-const reference is declared deprecated to produce compiler warning if used (usually implicitly).

OCCT code is updated to avoid that cast, occurring when function accepting non-const reference to handle is called with handle to derived type.
For that, local variable of argument type is passed instead, and down-cast is used to get it to desired type after the call.
A few occurrences of use of uninitialized variable are corrected.
This commit is contained in:
abv
2016-02-17 17:33:18 +03:00
parent fe9b8ff2f2
commit aa00364da7
59 changed files with 395 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/IGESSelect/IGESSelect_RebuildDrawings.cxx
View File

@@ -165,11 +165,14 @@ IGESSelect_RebuildDrawings::IGESSelect_RebuildDrawings ()
// si View() transfere, mettre a jour ...
for (setl.Start(); setl.More(); setl.Next()) {
DeclareAndCast(IGESData_IGESEntity,ent,setl.Value());
Handle(IGESData_ViewKindEntity) vieworig, viewnew;
vieworig = ent->View();
Handle(IGESData_ViewKindEntity) vieworig = ent->View();
if (vieworig.IsNull()) continue;
if (!TC.Search(vieworig,viewnew)) continue;
ent->InitView(viewnew);
Handle(Standard_Transient) aView;
if (!TC.Search(vieworig,aView)) continue;
Handle(IGESData_ViewKindEntity) viewnew =
Handle(IGESData_ViewKindEntity)::DownCast (aView);
if (! viewnew.IsNull())
ent->InitView(viewnew);
}
}