OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0026377: Passing Handle objects as arguments to functions as non-const reference to base type is dangerous

Browse Source 
Operator of cast to non-const reference is declared deprecated to produce compiler warning if used (usually implicitly).

OCCT code is updated to avoid that cast, occurring when function accepting non-const reference to handle is called with handle to derived type.
For that, local variable of argument type is passed instead, and down-cast is used to get it to desired type after the call.
A few occurrences of use of uninitialized variable are corrected.
This commit is contained in:
abv
2016-02-17 17:33:18 +03:00
parent fe9b8ff2f2
commit aa00364da7
59 changed files with 395 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/IGESDraw/IGESDraw_ToolViewsVisible.cxx
View File

@@ -169,7 +169,7 @@ void IGESDraw_ToolViewsVisible::OwnRenew
up = another->NbDisplayedEntities();
if (up == 0) return;
Handle(IGESData_HArray1OfIGESEntity) tempDisplayEntities;
Handle(IGESData_IGESEntity) anew;
Handle(Standard_Transient) anew;
for (I = 1; I <= up; I++) {
if (TC.Search (another->DisplayedEntity(I),anew)) newdisp.GetOneItem(anew);
}

2
src/IGESDraw/IGESDraw_ToolViewsVisibleWithAttr.cxx
View File

@@ -272,7 +272,7 @@ void IGESDraw_ToolViewsVisibleWithAttr::OwnRenew
up = another->NbDisplayedEntities();
if (up == 0) return;
Handle(IGESData_HArray1OfIGESEntity) tempDisplayEntities;
Handle(IGESData_IGESEntity) anew;
Handle(Standard_Transient) anew;
for (I = 1; I <= up; I++) {
if (TC.Search (another->DisplayedEntity(I),anew)) newdisp.GetOneItem(anew);
}