OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-07 18:30:55 +03:00
Code Packages Releases Activity

0025491: BRepOffsetAPI_MakeOffset algorithm crashes on customer's shape and big value of offset

Browse Source 
Test case for CR25491

Correction of test case for issue CR25491
This commit is contained in:
jgv 2014-11-21 15:22:22 +03:00 committed by bugmaster
parent 34e923b5c2
commit a791eb69f4
3 changed files with 47 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/BRepFill/BRepFill_OffsetWire.cxx
View File

@ -1253,29 +1253,6 @@ void BRepFill_OffsetWire::UpdateDetromp (BRepFill_DataMapOfOrientedShapeListOfSh
const Standard_Boolean EOnE, const Standard_Boolean EOnE,
const BRepFill_TrimEdgeTool& Trim) const const BRepFill_TrimEdgeTool& Trim) const
{ {
if (myJoinType == GeomAbs_Intersection &&
Vertices.Length() == 1 &&
!EOnE)
{
TopTools_IndexedMapOfShape Vmap1, Vmap2;
TopExp::MapShapes(Shape1, TopAbs_VERTEX, Vmap1);
TopExp::MapShapes(Shape2, TopAbs_VERTEX, Vmap2);
Standard_Boolean Adjacent = Standard_False;
for (Standard_Integer i = 1; i <= Vmap1.Extent(); i++)
for (Standard_Integer j = 1; j <= Vmap2.Extent(); j++)
if (Vmap1(i).IsSame(Vmap2(j)))
{
Adjacent = Standard_True;
break;
}
if (Adjacent)
{
Detromp(Shape1).Append(Vertices.First());
Detromp(Shape2).Append(Vertices.First());
return;
}
}
Standard_Integer ii = 1; Standard_Integer ii = 1;
Standard_Real U1,U2; Standard_Real U1,U2;
TopoDS_Vertex V1,V2; TopoDS_Vertex V1,V2;
@ -1295,7 +1272,10 @@ void BRepFill_OffsetWire::UpdateDetromp (BRepFill_DataMapOfOrientedShapeListOfSh
V2 = TopoDS::Vertex(Vertices.Value(ii)); V2 = TopoDS::Vertex(Vertices.Value(ii));
gp_Pnt2d P = Bis->Value((U2 + U1)*0.5); gp_Pnt2d P = Bis->Value((U2 + U1)*0.5);
if (!Trim.IsInside(P)) { Standard_Boolean IsP_inside = Standard_True;
if (myJoinType == GeomAbs_Arc)
IsP_inside = Trim.IsInside(P);
if (!IsP_inside) {
if (!V1.IsNull()) { if (!V1.IsNull()) {
Detromp(Shape1).Append(V1); Detromp(Shape1).Append(V1);
Detromp(Shape2).Append(V1); Detromp(Shape2).Append(V1);
@ -1313,7 +1293,10 @@ void BRepFill_OffsetWire::UpdateDetromp (BRepFill_DataMapOfOrientedShapeListOfSh
if (!EOnE) { if (!EOnE) {
if (!Precision::IsInfinite(U2)) { if (!Precision::IsInfinite(U2)) {
gp_Pnt2d P = Bis->Value((U2 + U1)*0.5); gp_Pnt2d P = Bis->Value((U2 + U1)*0.5);
if (!Trim.IsInside(P)) { Standard_Boolean IsP_inside = Standard_False;
if (myJoinType == GeomAbs_Arc)
IsP_inside = Trim.IsInside(P);
if (!IsP_inside) {
if (!V1.IsNull()) { if (!V1.IsNull()) {
Detromp(Shape1).Append(V1); Detromp(Shape1).Append(V1);
Detromp(Shape2).Append(V1); Detromp(Shape2).Append(V1);

12
tests/bugs/modalg_5/bug25298_09
View File

@ -17,17 +17,17 @@ if [catch { mkoffset resoffset pp 1 -1. i } ] {
} else { } else {
renamevar resoffset_1 result renamevar resoffset_1 result
set length 42 set length 32
set nb_v_good 6 set nb_v_good 5
set nb_e_good 7 set nb_e_good 5
set nb_w_good 2 set nb_w_good 1
set nb_f_good 0 set nb_f_good 0
set nb_sh_good 0 set nb_sh_good 0
set nb_sol_good 0 set nb_sol_good 0
set nb_compsol_good 0 set nb_compsol_good 0
set nb_compound_good 1 set nb_compound_good 0
set nb_shape_good 16 set nb_shape_good 11
display result display result
fit fit

32
tests/bugs/modalg_5/bug25491 Executable file
View File

@ -0,0 +1,32 @@
puts "============"
puts "OCC25491"
puts "============"
puts ""
#######################################################################
# BRepOffsetAPI_MakeOffset algorithm crashes on customer's shape and big value of offset
#######################################################################
restore [locate_data_file bug25491_offset_lines_2.brep] a
if [catch { mkoffset resoffset a 1 -35 i } ] {
puts "Error : mkoffset is wrong"
} else {
renamevar resoffset_1 result
set length 120
set nb_v_good 5
set nb_e_good 5
set nb_w_good 1
set nb_f_good 0
set nb_sh_good 0
set nb_sol_good 0
set nb_compsol_good 0
set nb_compound_good 0
set nb_shape_good 11
}
smallview
display a
fit
set only_screen_axo 1