OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-02 17:46:22 +03:00
Code Packages Releases Activity

0033866: Foundation Classes - BVH::SurfaceCalculator::Area() fails to calculate area of transformed box

Browse Source 
Use absolute values of intermediate calculations to compute surface area of a box, so they do not diminish each other.
This commit is contained in:
oan 2025-01-30 15:35:15 +00:00
parent bef42e89ef
commit a552a72514
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/BVH/BVH_Box.hxx
View File

@ -427,11 +427,11 @@ struct SurfaceCalculator<T, 2>
{ {
static T Area(const typename BVH_Box<T, 2>::BVH_VecNt& theSize) static T Area(const typename BVH_Box<T, 2>::BVH_VecNt& theSize)
{ {
const T anArea = theSize.x() * theSize.y(); const T anArea = std::abs (theSize.x() * theSize.y());
if (anArea < std::numeric_limits<T>::epsilon()) if (anArea < std::numeric_limits<T>::epsilon())
{ {
return theSize.x() + theSize.y(); return std::abs (theSize.x()) + std::abs (theSize.y());
} }
return anArea; return anArea;
@ -444,12 +444,14 @@ struct SurfaceCalculator<T, 3>
static T Area(const typename BVH_Box<T, 3>::BVH_VecNt& theSize) static T Area(const typename BVH_Box<T, 3>::BVH_VecNt& theSize)
{ {
const T anArea = const T anArea =
(theSize.x() * theSize.y() + theSize.x() * theSize.z() + theSize.z() * theSize.y()) (std::abs (theSize.x() * theSize.y()) +
std::abs (theSize.x() * theSize.z()) +
std::abs (theSize.z() * theSize.y()))
* static_cast<T>(2.0); * static_cast<T>(2.0);
if (anArea < std::numeric_limits<T>::epsilon()) if (anArea < std::numeric_limits<T>::epsilon())
{ {
return theSize.x() + theSize.y() + theSize.z(); return std::abs (theSize.x()) + std::abs (theSize.y()) + std::abs (theSize.z());
} }
return anArea; return anArea;
@ -462,12 +464,14 @@ struct SurfaceCalculator<T, 4>
static T Area(const typename BVH_Box<T, 4>::BVH_VecNt& theSize) static T Area(const typename BVH_Box<T, 4>::BVH_VecNt& theSize)
{ {
const T anArea = const T anArea =
(theSize.x() * theSize.y() + theSize.x() * theSize.z() + theSize.z() * theSize.y()) (std::abs (theSize.x() * theSize.y()) +
std::abs (theSize.x() * theSize.z()) +
std::abs (theSize.z() * theSize.y()))
* static_cast<T>(2.0); * static_cast<T>(2.0);
if (anArea < std::numeric_limits<T>::epsilon()) if (anArea < std::numeric_limits<T>::epsilon())
{ {
return theSize.x() + theSize.y() + theSize.z(); return std::abs (theSize.x()) + std::abs (theSize.y()) + std::abs (theSize.z());
} }
return anArea; return anArea;