OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0030597: Result of BRepOffsetAPI_MakePipeShell doesn't match the given profiles

Browse Source 
Modify the local function EdgeToBSpline of BRepFill_NSections to build a BSpline curve of general type for each curve of profile.
This commit is contained in:
jgv 2019-12-18 18:24:16 +03:00 committed by bugmaster
parent c68c346d2b
commit 9a1701fbcb
2 changed files with 38 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/BRepFill/BRepFill_NSections.cxx
View File

@ -105,20 +105,15 @@ static Handle(Geom_BSplineCurve) EdgeToBSpline (const TopoDS_Edge& theEdge)
Handle(Geom_Curve) aCurve = BRep_Tool::Curve (theEdge, aLoc, aFirst, aLast);
// convert its part used by edge to bspline; note that if edge curve is bspline,
// conversion made via trimmed curve is still needed -- it will copy it, segment
// as appropriate, and remove periodicity if it is periodic (deadly for approximator)
// approximation or conversion made via trimmed curve is still needed -- it will copy it,
// segment as appropriate, and remove periodicity if it is periodic (deadly for approximator)
Handle(Geom_TrimmedCurve) aTrimCurve = new Geom_TrimmedCurve (aCurve, aFirst, aLast);
// special treatment of conic curve
if (aTrimCurve->BasisCurve()->IsKind(STANDARD_TYPE(Geom_Conic)))
{
const Handle(Geom_Curve)& aCurveTemp = aTrimCurve; // to avoid ambiguity
GeomConvert_ApproxCurve anAppr (aCurveTemp, Precision::Confusion(), GeomAbs_C1, 16, 14);
if (anAppr.HasResult())
aBSCurve = anAppr.Curve();
}
const Handle(Geom_Curve)& aCurveTemp = aTrimCurve; // to avoid ambiguity
GeomConvert_ApproxCurve anAppr (aCurveTemp, Precision::Confusion(), GeomAbs_C1, 16, 14);
if (anAppr.HasResult())
aBSCurve = anAppr.Curve();
// general case
if (aBSCurve.IsNull())
aBSCurve = GeomConvert::CurveToBSplineCurve (aTrimCurve);

36
tests/bugs/modalg_7/bug30597
View File

@ -1,6 +1,6 @@
puts "================================================================"
puts "OCC30597: BRepOffsetAPI_MakePipeShell raises Standard_RangeError"
puts "================================================================"
puts "================================================================================"
puts "OCC30597: Result of BRepOffsetAPI_MakePipeShell doesn't match the given profiles"
puts "================================================================================"
puts ""
restore [locate_data_file bug30597_compound.brep] a
@ -16,4 +16,32 @@ addsweep a_3_1 a_1_2
buildsweep result
checkprops result -s 0.95884
checkprops result -s 0.880677
explode result e
explode a_2_1
mkcurve c2 a_2_1_1
cvalue c2 pi x2 y2 z2
vertex v2 x2 y2 z2
distmini d2 v2 result_2
if {[dval d2_val] > 1.e-7} {
puts "Error: result is far from first profile"
}
explode a_3_1
mkcurve c3 a_3_1_1
cvalue c3 pi x3 y3 z3
vertex v3 x3 y3 z3
distmini d3 v3 result_3
if {[dval d3_val] > 1.e-7} {
puts "Error: result is far from second profile"
}
smallview
donly result a_2_1 a_3_1
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png