OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0033410: Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries

Browse Source 
Problem fixed by using array of nodes in case when aPnindices is empty.
This commit is contained in:
ichesnok 2024-03-12 18:01:09 +00:00 committed by Vadim Glukhikh
parent 74095a8b46
commit 983e35ed71
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/StepToTopoDS/StepToTopoDS_TranslateFace.cxx
View File

@ -105,12 +105,13 @@ namespace {
// ============================================================================ // ============================================================================
static void SetNodes(const Handle(Poly_Triangulation)& theMesh, static void SetNodes(const Handle(Poly_Triangulation)& theMesh,
Handle(TColgp_HArray1OfXYZ)& theNodes, Handle(TColgp_HArray1OfXYZ)& theNodes,
const Standard_Integer theNumPnindex,
Handle(TColStd_HArray1OfInteger)& thePnindices, Handle(TColStd_HArray1OfInteger)& thePnindices,
const Standard_Real theLengthFactor) const Standard_Real theLengthFactor)
{ {
for (Standard_Integer aPnIndex = 1; aPnIndex <= theMesh->NbNodes(); ++aPnIndex) for (Standard_Integer aPnIndex = 1; aPnIndex <= theMesh->NbNodes(); ++aPnIndex)
{ {
const gp_XYZ& aPoint = theNodes->Value(thePnindices->Value(aPnIndex)); const gp_XYZ& aPoint = theNodes->Value((theNumPnindex > 0) ? thePnindices->Value(aPnIndex) : aPnIndex);
theMesh->SetNode(aPnIndex, theLengthFactor * aPoint); theMesh->SetNode(aPnIndex, theLengthFactor * aPoint);
} }
} }
@ -326,10 +327,11 @@ namespace {
const Standard_Boolean aHasUVNodes = Standard_False; const Standard_Boolean aHasUVNodes = Standard_False;
const Standard_Boolean aHasNormals = (aNormNum > 0); const Standard_Boolean aHasNormals = (aNormNum > 0);
const Standard_Integer aNbNodes = (aNumPnindex > 0) ? aNumPnindex : aNodes->Length();
if (aTrianStripsNum == 0 && aTrianFansNum == 0) if (aTrianStripsNum == 0 && aTrianFansNum == 0)
{ {
aMesh = new Poly_Triangulation(aNumPnindex, aTrianNum, aHasUVNodes, aHasNormals); aMesh = new Poly_Triangulation(aNbNodes, aTrianNum, aHasUVNodes, aHasNormals);
} }
else else
{ {
@ -359,14 +361,14 @@ namespace {
aNbTriaFans += aTriangleFan->Length() - 2; aNbTriaFans += aTriangleFan->Length() - 2;
} }
aMesh = new Poly_Triangulation(aNumPnindex, aNbTriaStrips + aNbTriaFans, aHasUVNodes, aHasNormals); aMesh = new Poly_Triangulation(aNbNodes, aNbTriaStrips + aNbTriaFans, aHasUVNodes, aHasNormals);
} }
SetNodes(aMesh, aNodes, aPnindices, theLocalFactors.LengthFactor()); SetNodes(aMesh, aNodes, aNumPnindex, aPnindices, theLocalFactors.LengthFactor());
if (aHasNormals) if (aHasNormals)
{ {
SetNormals(aMesh, aNormals, aNormNum, aNumPnindex); SetNormals(aMesh, aNormals, aNormNum, aNbNodes);
} }
SetTriangles(aMesh, aTriangles, aTrianStripsNum, aTriaStrips, aTrianFansNum, aTriaFans); SetTriangles(aMesh, aTriangles, aTrianStripsNum, aTriaStrips, aTrianFansNum, aTriaFans);

12
tests/bugs/step/bug33410 Normal file
View File

@ -0,0 +1,12 @@
puts "========================"
puts "0033410: Data Exchange, Step Import - TRIANGULATED_FACE from STEP where there are no pnval entries"
puts "========================"
pload OCAF
# Read file
ReadStep D [locate_data_file bug33410.step]
XGetOneShape sh D
checktrinfo sh -face 1 -nod 81 -tri 128
Close D