OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0031199: BRepMesh fails on thin faces

Browse Source 
Use real tolerance of a face to define threshold for tolerance of discrete model instead of empirical values based on discrete model itself
This commit is contained in:
oan 2019-12-04 12:26:10 +03:00 committed by bugmaster
parent 6ef7a1f9e5
commit 936ce1f273
26 changed files with 111 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/BRepMesh/BRepMesh_DefaultRangeSplitter.cxx
View File

@ -18,6 +18,7 @@
#include <GCPnts_AbscissaPoint.hxx> #include <GCPnts_AbscissaPoint.hxx>
#include <GeomAdaptor_Curve.hxx> #include <GeomAdaptor_Curve.hxx>
#include <GeomAbs_IsoType.hxx> #include <GeomAbs_IsoType.hxx>
#include <BRep_Tool.hxx>
//======================================================================= //=======================================================================
// Function: Reset // Function: Reset
@ -125,9 +126,14 @@ void BRepMesh_DefaultRangeSplitter::computeTolerance(
const Standard_Real aDiffU = myRangeU.second - myRangeU.first; const Standard_Real aDiffU = myRangeU.second - myRangeU.first;
const Standard_Real aDiffV = myRangeV.second - myRangeV.first; const Standard_Real aDiffV = myRangeV.second - myRangeV.first;
const Standard_Real aTolerance = BRep_Tool::Tolerance (myDFace->GetFace());
const Adaptor3d_Surface& aSurface = GetSurface()->Surface();
const Standard_Real aResU = aSurface.UResolution (aTolerance);
const Standard_Real aResV = aSurface.VResolution (aTolerance);
const Standard_Real aDeflectionUV = 1.e-05; const Standard_Real aDeflectionUV = 1.e-05;
myTolerance.first = Max(Min(aDeflectionUV, 0.1 * aDiffU), 1e-7 * aDiffU); myTolerance.first = Max(Min(aDeflectionUV, aResU), 1e-7 * aDiffU);
myTolerance.second = Max(Min(aDeflectionUV, 0.1 * aDiffV), 1e-7 * aDiffV); myTolerance.second = Max(Min(aDeflectionUV, aResV), 1e-7 * aDiffV);
} }
//======================================================================= //=======================================================================

2
tests/bugs/iges/buc60823
View File

@ -14,6 +14,6 @@ vdisplay result
vsetdispmode result 1 vsetdispmode result 1
vfit vfit
checktrinfo result -tri 2708 -nod 2608 checktrinfo result -tri 2711 -nod 2611
checkview -display result -2d -path ${imagedir}/${test_image}.png checkview -display result -2d -path ${imagedir}/${test_image}.png

2
tests/bugs/iges/bug306
View File

@ -20,7 +20,7 @@ vsetdispmode result 1
vdisplay result vdisplay result
vfit vfit
checktrinfo result -tri 5812 -nod 5809 checktrinfo result -tri 5814 -nod 5811
checkmaxtol result -ref 0.92213088179312575 checkmaxtol result -ref 0.92213088179312575
checknbshapes result -shell 1 checknbshapes result -shell 1

2
tests/bugs/mesh/bug23513
View File

@ -12,7 +12,7 @@ vfit
checkview -screenshot -3d -path ${imagedir}/${test_image}.png checkview -screenshot -3d -path ${imagedir}/${test_image}.png
checktrinfo result -tri 323648 -nod 161865 -defl 0.00096399964870812682 checktrinfo result -tri 323820 -nod 161951 -defl 0.00096399964870812682
set log [tricheck result] set log [tricheck result]
if { [llength $log] != 0 } { if { [llength $log] != 0 } {

2
tests/bugs/mesh/bug25827
View File

@ -1,4 +1,4 @@
puts "TODO CR25827 ALL: Faulty shapes in variables faulty_" #puts "TODO CR25827 ALL: Faulty shapes in variables faulty_"
puts "=========" puts "========="
puts "CR25827" puts "CR25827"

2
tests/bugs/mesh/bug29962
View File

@ -27,7 +27,7 @@ if { [llength $log2] != 0 } {
puts "Mesh is OK" puts "Mesh is OK"
} }
checktrinfo result -tri 78186 -nod 39096 -defl 0.035123046705520911 checktrinfo result -tri 78200 -nod 39103 -defl 0.035123046705520911
don result don result
isos result 0 isos result 0

19
tests/bugs/mesh/bug31199_1 Normal file
View File

@ -0,0 +1,19 @@
puts "======="
puts "0031199: BRepMesh fails on thin faces"
puts "======="
puts ""
restore [locate_data_file bug31199_ok.brep] result
incmesh result 0.1
checktrinfo result -tri 90 -nod 90
donly result
triangles result
isos result 0
top
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png

19
tests/bugs/mesh/bug31199_2 Normal file
View File

@ -0,0 +1,19 @@
puts "======="
puts "0031199: BRepMesh fails on thin faces"
puts "======="
puts ""
restore [locate_data_file bug31199_failure1.brep] result
incmesh result 0.1
checktrinfo result -tri 90 -nod 92
donly result
triangles result
isos result 0
top
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png

19
tests/bugs/mesh/bug31199_3 Normal file
View File

@ -0,0 +1,19 @@
puts "======="
puts "0031199: BRepMesh fails on thin faces"
puts "======="
puts ""
restore [locate_data_file bug31199_failure2.brep] result
incmesh result 0.1
checktrinfo result -tri 78 -nod 80
donly result
triangles result
isos result 0
top
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png

19
tests/bugs/mesh/bug31199_4 Normal file
View File

@ -0,0 +1,19 @@
puts "======="
puts "0031199: BRepMesh fails on thin faces"
puts "======="
puts ""
restore [locate_data_file bug31199_failure3.brep] result
incmesh result 0.1
checktrinfo result -tri 78 -nod 80
donly result
triangles result
isos result 0
top
fit
checkview -screenshot -2d -path ${imagedir}/${test_image}.png

2
tests/bugs/moddata_1/bug15519
View File

@ -14,5 +14,5 @@ tclean result
set Deflection 1. set Deflection 1.
catch {incmesh result ${Deflection} } catch {incmesh result ${Deflection} }
checktrinfo result -tri 52685 -nod 46258 -defl 1.0 -tol_rel_defl 0.001 -tol_rel_tri 0.001 -tol_rel_nod 0.001 checktrinfo result -tri 52956 -nod 46525 -defl 1.0 -tol_rel_defl 0.001 -tol_rel_tri 0.001 -tol_rel_nod 0.001
checkview -display result -2d -path ${imagedir}/${test_image}.png checkview -display result -2d -path ${imagedir}/${test_image}.png

2
tests/bugs/moddata_1/bug22759
View File

@ -19,7 +19,7 @@ tclean result
set Deflection 0.001 set Deflection 0.001
incmesh result ${Deflection} incmesh result ${Deflection}
checktrinfo result -tri 346096 -nod 176022 -defl 0.0092442421472206764 -tol_rel_defl 0.001 -tol_rel_tri 0.001 -tol_rel_nod 0.001 checktrinfo result -tri 375392 -nod 190670 -defl 0.0092442421472206764 -tol_rel_defl 0.001 -tol_rel_tri 0.001 -tol_rel_nod 0.001
vinit vinit
vdisplay result vdisplay result

2
tests/bugs/moddata_2/bug258_1
View File

@ -15,5 +15,5 @@ vsetdispmode result 1
vfit vfit
triangles result triangles result
checktrinfo result -tri 78 -nod 80 checktrinfo result -tri 78 -nod 82
checkview -screenshot -3d -path ${imagedir}/${test_image}.png checkview -screenshot -3d -path ${imagedir}/${test_image}.png

2
tests/bugs/moddata_2/bug428
View File

@ -19,5 +19,5 @@ isos result 0
triangles result triangles result
fit fit
checktrinfo result -tri 10886 -nod 7830 checktrinfo result -tri 10924 -nod 7869
checkview -screenshot -2d -path ${imagedir}/${test_image}_axo.png checkview -screenshot -2d -path ${imagedir}/${test_image}_axo.png

2
tests/hlr/poly_hlr/C17
View File

@ -1,5 +1,5 @@
set viewname "vright" set viewname "vright"
set length 2234.46 set length 2234.38
testreadstep [locate_data_file bug27341_CCT_PMK_32_L_o_CAD.stp] a testreadstep [locate_data_file bug27341_CCT_PMK_32_L_o_CAD.stp] a
COMPUTE_HLR $viewname $algotype COMPUTE_HLR $viewname $algotype

2
tests/hlr/poly_hlr/C4
View File

@ -1,4 +1,4 @@
puts "TODO OCC30286 ALL: Error : The length of result shape is 2707.46, expected 2765.47" puts "TODO OCC30286 ALL: Error : The length of result shape is 2707.33, expected 2765.47"
set viewname "vright" set viewname "vright"
set length 2765.47 set length 2765.47

2
tests/hlr/poly_hlr/bug27979_1
View File

@ -1,4 +1,4 @@
puts "TODO OCC30286 ALL: Error : The length of result shape is 3.5348, expected 3." puts "TODO OCC30286 ALL: Error : The length of result shape is 3.53405, expected 3."
puts "========================================================================" puts "========================================================================"
puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo" puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo"

2
tests/hlr/poly_hlr/bug27979_2
View File

@ -1,4 +1,4 @@
puts "TODO OCC30286 ALL: Error : The length of result shape is 12.4882, expected 12." puts "TODO OCC30286 ALL: Error : The length of result shape is 12.4883, expected 12."
puts "========================================================================" puts "========================================================================"
puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo" puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo"

2
tests/hlr/poly_hlr/bug27979_4
View File

@ -1,4 +1,4 @@
puts "TODO OCC30286 ALL: Error : The length of result shape is 11.4456, expected 11." puts "TODO OCC30286 ALL: Error : The length of result shape is 11.4458, expected 11."
puts "========================================================================" puts "========================================================================"
puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo" puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo"

2
tests/hlr/poly_hlr/bug27979_6
View File

@ -1,4 +1,4 @@
puts "TODO OCC30286 ALL: Error : The length of result shape is 11.2106, expected 11." puts "TODO OCC30286 ALL: Error : The length of result shape is 11.2065, expected 11."
puts "========================================================================" puts "========================================================================"
puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo" puts "OCC27979: Parasolid converted BREP shows weird lines on hidden line Algo"

4
tests/mesh/data/advanced/B2
View File

@ -1,7 +1,7 @@
set TheFileName OCC22145.stp set TheFileName OCC22145.stp
set bug_freenodes "OCC22687" set bug_freenodes "OCC22687"
set bug_cross "OCC22687" #set bug_cross "OCC22687"
set nbcross(ALL) 8 #set nbcross(ALL) 8
if { [string compare $command "shading"] == 0 } { if { [string compare $command "shading"] == 0 } {
set nbfreenodes(ALL) 4 set nbfreenodes(ALL) 4
} else { } else {

4
tests/mesh/data/advanced/B3
View File

@ -1,7 +1,7 @@
set TheFileName OCC22145.stp set TheFileName OCC22145.stp
set bug_freenodes "OCC22687" set bug_freenodes "OCC22687"
set bug_cross "OCC22687" #set bug_cross "OCC22687"
set nbcross(ALL) 8 #set nbcross(ALL) 8
if { [string compare $command "shading"] == 0 } { if { [string compare $command "shading"] == 0 } {
set nbfreenodes(ALL) 4 set nbfreenodes(ALL) 4
} else { } else {

4
tests/mesh/data/advanced/B7
View File

@ -1,8 +1,8 @@
set TheFileName OCC22302.brep set TheFileName OCC22302.brep
set bug_freenodes "OCC22687" set bug_freenodes "OCC22687"
set bug_area "OCC22687" set bug_area "OCC22687"
set bug_cross "OCC22687" #set bug_cross "OCC22687"
set nbcross(ALL) 8 #set nbcross(ALL) 8
if { [string compare $command "shading"] == 0 } { if { [string compare $command "shading"] == 0 } {
set nbfreenodes(ALL) 4 set nbfreenodes(ALL) 4
} else { } else {

4
tests/mesh/data/standard/H5
View File

@ -1,3 +1,3 @@
set TheFileName shading_068.brep set TheFileName shading_068.brep
set bug_cross "OCC22687" #set bug_cross "OCC22687"
set nbcross(ALL) 2 #set nbcross(ALL) 2

4
tests/mesh/data/standard/M8
View File

@ -5,5 +5,5 @@ if { [string compare $command "shading"] == 0 } {
} else { } else {
set rel_tol 6.376860334255998 set rel_tol 6.376860334255998
} }
set bug_freenodes "M8" #set bug_freenodes "M8"
set nbfreenodes(All) 1 #set nbfreenodes(All) 1

2
tests/mesh/data/standard/P8
View File

@ -1 +1,3 @@
set TheFileName shading_143.brep set TheFileName shading_143.brep
set bug_freenodes "P8"
set nbfreenodes(ALL) 2