OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0030897: Modeling Algorithms - Crash in UnifySameDomain [Regression]

Browse Source 
The regression caused by the patch for 0030534 has been eliminated. For that the method InsertWiresIntoFaces() has been corrected: the face to which a wire is added is first oriented as forward.
This commit is contained in:
msv 2019-08-13 16:00:48 +03:00 committed by bugmaster
parent 2546fd477f
commit 8e7dc6f465
2 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
View File

@ -377,7 +377,7 @@ static void InsertWiresIntoFaces(const TopTools_SequenceOfShape& theWires,
const TopoDS_Edge& anEdge = TopoDS::Edge(iter.Value()); const TopoDS_Edge& anEdge = TopoDS::Edge(iter.Value());
BRepAdaptor_Curve2d BAcurve2d(anEdge, theRefFace); BRepAdaptor_Curve2d BAcurve2d(anEdge, theRefFace);
gp_Pnt2d aPnt2d = BAcurve2d.Value((BAcurve2d.FirstParameter() + BAcurve2d.LastParameter())/2.); gp_Pnt2d aPnt2d = BAcurve2d.Value((BAcurve2d.FirstParameter() + BAcurve2d.LastParameter())/2.);
TopoDS_Face RequiredFace; TopoDS_Shape RequiredFace;
for (Standard_Integer jj = 1; jj <= theFaces.Length(); jj++) for (Standard_Integer jj = 1; jj <= theFaces.Length(); jj++)
{ {
const TopoDS_Face& aFace = TopoDS::Face(theFaces(jj)); const TopoDS_Face& aFace = TopoDS::Face(theFaces(jj));
@ -385,11 +385,18 @@ static void InsertWiresIntoFaces(const TopTools_SequenceOfShape& theWires,
TopAbs_State aStatus = Classifier.Perform(aPnt2d); TopAbs_State aStatus = Classifier.Perform(aPnt2d);
if (aStatus == TopAbs_IN) if (aStatus == TopAbs_IN)
{ {
RequiredFace = aFace; RequiredFace = aFace.Oriented (TopAbs_FORWARD);
break; break;
} }
} }
BB.Add(RequiredFace, aWire); if (!RequiredFace.IsNull())
{
BB.Add(RequiredFace, aWire);
}
else
{
Standard_ASSERT_INVOKE ("ShapeUpgrade_UnifySameDomain: wire remains unclassified");
}
} }
} }

20
tests/bugs/modalg_7/bug30897 Normal file
View File

@ -0,0 +1,20 @@
puts "======================================================="
puts "0030897: Modeling Algorithms - Crash in UnifySameDomain"
puts "======================================================="
puts ""
restore [locate_data_file bug30897_bleriot_16.brep] a
unifysamedom result a
checkshape result
checknbshapes result -solid 1 -shell 1 -face 51 -wire 121 -edge 379 -vertex 324
set tolres [checkmaxtol result]
if { ${tolres} > 0.00385} {
puts "Error: bad tolerance of result"
}
checkprops result -v 403016