OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

026464: BRepOffset_MakeOffset does not provide valid output

Browse Source 
Handling of degenerated case improved.

Test-case for issue #26464
This commit is contained in:
aml 2015-07-29 16:14:09 +03:00 committed by bugmaster
parent 016dfb16ba
commit 8948e7784a
2 changed files with 40 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/BRepOffset/BRepOffset_Offset.cxx
View File

@ -537,11 +537,29 @@ void BRepOffset_Offset::Init(const TopoDS_Face& Face,
TopTools_SequenceOfShape DegEdges; TopTools_SequenceOfShape DegEdges;
TopExp_Explorer Explo(Face, TopAbs_EDGE); TopExp_Explorer Explo(Face, TopAbs_EDGE);
for (; Explo.More(); Explo.Next()) for (; Explo.More(); Explo.Next())
{ {
const TopoDS_Edge& anEdge = TopoDS::Edge(Explo.Current()); const TopoDS_Edge& anEdge = TopoDS::Edge(Explo.Current());
if (BRep_Tool::Degenerated(anEdge))
DegEdges.Append(anEdge); if (BRep_Tool::Degenerated(anEdge))
} {
Standard_Real aF, aL;
Handle(Geom2d_Curve) c2d = BRep_Tool::CurveOnSurface(anEdge, Face, aF, aL);
gp_Pnt2d aFPnt2d = c2d->Value(aF),
aLPnt2d = c2d->Value(aL);
gp_Pnt aFPnt = S->Value(aFPnt2d.X(), aFPnt2d.Y()),
aLPnt = S->Value(aLPnt2d.X(), aLPnt2d.Y());
// aFPnt.SquareDistance(aLPnt) > Precision::SquareConfusion() -
// is a sufficient condition of troubles: non-singular case, but edge is degenerated.
// So, normal handling of degenerated edges is not applicable in case of non-singular point.
if (aFPnt.SquareDistance(aLPnt) < Precision::SquareConfusion())
{
DegEdges.Append(anEdge);
}
}
}
if (!DegEdges.IsEmpty()) if (!DegEdges.IsEmpty())
{ {
const Standard_Real TolApex = 1.e-5; const Standard_Real TolApex = 1.e-5;
@ -1640,6 +1658,3 @@ BRepOffset_Status BRepOffset_Offset::Status() const
{ {
return myStatus; return myStatus;
} }

17
tests/bugs/modalg_6/bug26464 Normal file
View File

@ -0,0 +1,17 @@
puts "========"
puts "OCC26464"
puts "========"
puts ""
#######################################################
# BRepOffset_MakeOffset does not provide valid output
#######################################################
smallview
restore [locate_data_file OCC26464-extracted_Plate5520contour.brep] sh
offsetparameter 1e-7 p i
offsetload sh 60
offsetperform r
fit
set only_screen_axo 1