OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-05 18:16:23 +03:00
Code Packages Releases Activity

0023264: cppcheck warning: Logical conjunction always evaluates to false

Browse Source 
Replaced the '&&' operator with '||'. Otherwise the logical conjunction always evaluates to false.
This commit is contained in:
Pawel 2012-07-12 10:17:38 +02:00 committed by Pawel Kowalski
parent 207e57e4c2
commit 76021966ce
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Visual3d/Visual3d_Light.cxx
View File

@ -140,11 +140,11 @@ MyType (Visual3d_TOLS_POSITIONAL) {
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
if ( (Fact1 < 0.0) && (Fact1 > 1.0) ) if ( (Fact1 < 0.0) || (Fact1 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
if ( (Fact2 < 0.0) && (Fact2 > 1.0) ) if ( (Fact2 < 0.0) || (Fact2 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
@ -186,11 +186,11 @@ MyType (Visual3d_TOLS_SPOT) {
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
if ( (Fact1 < 0.0) && (Fact1 > 1.0) ) if ( (Fact1 < 0.0) || (Fact1 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
if ( (Fact2 < 0.0) && (Fact2 > 1.0) ) if ( (Fact2 < 0.0) || (Fact2 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
@ -378,7 +378,7 @@ void Visual3d_Light::SetAngle (const Standard_Real AngleCone) {
void Visual3d_Light::SetAttenuation1 (const Standard_Real Fact1) { void Visual3d_Light::SetAttenuation1 (const Standard_Real Fact1) {
if ( (Fact1 < 0.0) && (Fact1 > 1.0) ) if ( (Fact1 < 0.0) || (Fact1 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");
@ -399,7 +399,7 @@ void Visual3d_Light::SetAttenuation1 (const Standard_Real Fact1) {
void Visual3d_Light::SetAttenuation2 (const Standard_Real Fact2) { void Visual3d_Light::SetAttenuation2 (const Standard_Real Fact2) {
if ( (Fact2 < 0.0) && (Fact2 > 1.0) ) if ( (Fact2 < 0.0) || (Fact2 > 1.0) )
Visual3d_LightDefinitionError::Raise Visual3d_LightDefinitionError::Raise
("Bad value for LightAttenuation"); ("Bad value for LightAttenuation");