OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0031010: Foundation Classes - heap-buffer-overflow reported by Clang address sanitizer in OSD_Path::IsUncExtendedPath()

Browse Source 
Use of memcmp is replaced by strncmp to avoid possible read access out of string buffer size
This commit is contained in:
abv 2019-09-30 21:37:55 +03:00
parent 3358ed643b
commit 683b72c3c1
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/OSD/OSD_Path.hxx
View File

@ -228,7 +228,10 @@ public:
//! \\?\D:\very long path //! \\?\D:\very long path
//! File I/O functions in the Windows API convert "/" to "\" as part of converting the name to an NT-style name, except when using the "\\?\" prefix. //! File I/O functions in the Windows API convert "/" to "\" as part of converting the name to an NT-style name, except when using the "\\?\" prefix.
//! @return true if extended-length NT path syntax detected. //! @return true if extended-length NT path syntax detected.
static Standard_Boolean IsNtExtendedPath (const char* thePath) { return ::memcmp (thePath, "\\\\?\\", 4) == 0; } static Standard_Boolean IsNtExtendedPath (const char* thePath)
{
return ::strncmp (thePath, "\\\\?\\", 4) == 0;
}
//! UNC is a naming convention used primarily to specify and map network drives in Microsoft Windows. //! UNC is a naming convention used primarily to specify and map network drives in Microsoft Windows.
//! Sample path: //! Sample path:
@ -236,31 +239,40 @@ public:
//! @return true if UNC path syntax detected. //! @return true if UNC path syntax detected.
static Standard_Boolean IsUncPath (const char* thePath) static Standard_Boolean IsUncPath (const char* thePath)
{ {
if (::memcmp (thePath, "\\\\", 2) == 0) if (::strncmp (thePath, "\\\\", 2) == 0)
{ {
return thePath[2] != '?' return thePath[2] != '?'
|| IsUncExtendedPath (thePath); || IsUncExtendedPath (thePath);
} }
return ::memcmp (thePath, "//", 2) == 0; return ::strncmp (thePath, "//", 2) == 0;
} }
//! Detect extended-length UNC path. //! Detect extended-length UNC path.
//! Sample path: //! Sample path:
//! \\?\UNC\server\share //! \\?\UNC\server\share
//! @return true if extended-length UNC path syntax detected. //! @return true if extended-length UNC path syntax detected.
static Standard_Boolean IsUncExtendedPath (const char* thePath) { return ::memcmp (thePath, "\\\\?\\UNC\\", 8) == 0; } static Standard_Boolean IsUncExtendedPath (const char* thePath)
{
return ::strncmp (thePath, "\\\\?\\UNC\\", 8) == 0;
}
//! Detect absolute UNIX-path. //! Detect absolute UNIX-path.
//! Sample path: //! Sample path:
//! /media/cdrom/file //! /media/cdrom/file
//! @return true if UNIX path syntax detected. //! @return true if UNIX path syntax detected.
static Standard_Boolean IsUnixPath (const char* thePath) { return thePath[0] == '/' && thePath[1] != '/'; } static Standard_Boolean IsUnixPath (const char* thePath)
{
return thePath[0] == '/' && thePath[1] != '/';
}
//! Detect special URLs on Android platform. //! Detect special URLs on Android platform.
//! Sample path: //! Sample path:
//! content://filename //! content://filename
//! @return true if content path syntax detected //! @return true if content path syntax detected
static Standard_Boolean IsContentProtocolPath (const char* thePath) { return ::memcmp (thePath, "content://", 10) == 0; } static Standard_Boolean IsContentProtocolPath (const char* thePath)
{
return ::strncmp (thePath, "content://", 10) == 0;
}
//! Detect remote protocol path (http / ftp / ...). //! Detect remote protocol path (http / ftp / ...).
//! Actually shouldn't be remote... //! Actually shouldn't be remote...