OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-16 10:08:36 +03:00
Code

0031492: BRepBuilderAPI_MakeFace crashes on a wire

Browse Source 
Method BRepClass_Intersector::LocalGeometry is modified: check whether is tangent defined and check of infinite curvature is added.
This commit is contained in:
jgv 2020-04-10 11:52:37 +03:00
parent 67a843c0d4
commit 5a2f31c887
2 changed files with 57 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/BRepClass/BRepClass_Intersector.cxx
View File

@ -35,6 +35,13 @@
#include <TopExp.hxx> #include <TopExp.hxx>
#include <TopoDS_Vertex.hxx> #include <TopoDS_Vertex.hxx>
static
void GetTangentAsChord(const Handle(Geom2d_Curve)& thePCurve,
gp_Dir2d& theTangent,
const Standard_Real theParam,
const Standard_Real theFirst,
const Standard_Real theLast);
static static
void RefineTolerance(const TopoDS_Face& aF, void RefineTolerance(const TopoDS_Face& aF,
const Geom2dAdaptor_Curve& aC, const Geom2dAdaptor_Curve& aC,
@ -169,12 +176,21 @@ void BRepClass_Intersector::LocalGeometry(const BRepClass_Edge& E,
gp_Dir2d& Norm, gp_Dir2d& Norm,
Standard_Real& C) const Standard_Real& C) const
{ {
Standard_Real f,l; Standard_Real fpar, lpar;
Geom2dLProp_CLProps2d Prop(BRep_Tool::CurveOnSurface(E.Edge(),E.Face(),f,l), Handle(Geom2d_Curve) aPCurve = BRep_Tool::CurveOnSurface(E.Edge(), E.Face(), fpar, lpar);
U,2,Precision::PConfusion()); Geom2dLProp_CLProps2d Prop(aPCurve, U, 2, Precision::PConfusion());
C = 0.;
if (Prop.IsTangentDefined())
{
Prop.Tangent(Tang); Prop.Tangent(Tang);
C = Prop.Curvature(); C = Prop.Curvature();
if (C > Precision::PConfusion()) }
else
GetTangentAsChord(aPCurve, Tang, U, fpar, lpar);
if (C > Precision::PConfusion() &&
!Precision::IsInfinite(C))
Prop.Normal(Norm); Prop.Normal(Norm);
else else
Norm.SetCoord(Tang.Y(),-Tang.X()); Norm.SetCoord(Tang.Y(),-Tang.X());
@ -220,4 +236,31 @@ void RefineTolerance(const TopoDS_Face& aF,
} }
} }
//=======================================================================
//function : GetTangentAsChord
//purpose :
//=======================================================================
void GetTangentAsChord(const Handle(Geom2d_Curve)& thePCurve,
gp_Dir2d& theTangent,
const Standard_Real theParam,
const Standard_Real theFirst,
const Standard_Real theLast)
{
Standard_Real Offset = 0.1*(theLast - theFirst);
if (theLast - theParam < Precision::PConfusion()) //theParam == theLast
Offset *= -1;
else if (theParam + Offset > theLast) //<theParam> is close to <theLast>
Offset = 0.5*(theLast - theParam);
gp_Pnt2d aPnt2d = thePCurve->Value(theParam);
gp_Pnt2d OffsetPnt2d = thePCurve->Value(theParam + Offset);
gp_Vec2d aChord(aPnt2d, OffsetPnt2d);
if (Offset < 0.)
aChord.Reverse();
Standard_Real SqLength = aChord.SquareMagnitude();
if (SqLength > Precision::SquarePConfusion())
theTangent = aChord;
}

8
tests/bugs/modalg_7/bug31492 Normal file
View File

@ -0,0 +1,8 @@
puts "==================================================="
puts "OCC31492: BRepBuilderAPI_MakeFace crashes on a wire"
puts "==================================================="
puts ""
brestore [locate_data_file bug31492.brep] a
mkplane result a