OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0032301: Visualization, TKOpenGl - depth peeling is broken with OpenGl_Caps::buffersOpaqueAlpha option

Browse Source 
OpenGl_LayerList::renderTransparent() - color mask is now set to write into Alpha channel of depth peeling FBOs.
OpenGl_View::blitBuffers() - avoid using undefined color for glClear(GL_COLOR_BUFFER_BIT) operation.
This commit is contained in:
kgv 2021-04-15 15:34:52 +03:00 committed by bugmaster
parent b907cca37e
commit 57357010a8
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/OpenGl/OpenGl_LayerList.cxx
View File

@ -966,6 +966,7 @@ void OpenGl_LayerList::renderTransparent (const Handle(OpenGl_Workspace)& theW
// initialize min/max depth buffer
aGlBlendBackFBO->BindDrawBuffer (aCtx);
aCtx->SetDrawBuffers (1, THE_DRAW_BUFFERS0);
aCtx->SetColorMaskRGBA (NCollection_Vec4<bool> (true)); // force writes into all components, including alpha
aCtx->core20fwd->glClearColor (0.0f, 0.0f, 0.0f, 0.0f);
aCtx->core20fwd->glClear (GL_COLOR_BUFFER_BIT);
@ -1122,6 +1123,7 @@ void OpenGl_LayerList::renderTransparent (const Handle(OpenGl_Workspace)& theW
theReadDrawFbo->BindBuffer (aCtx);
}
aCtx->SetDrawBuffers (1, THE_DRAW_BUFFERS0);
aCtx->SetColorMask (true); // update writes into alpha component
break;
}
}

1
src/OpenGl/OpenGl_View.cxx
View File

@ -2558,6 +2558,7 @@ bool OpenGl_View::blitBuffers (OpenGl_FrameBuffer* theReadFbo,
aCtx->SetColorMaskRGBA (NCollection_Vec4<bool> (true)); // force writes into all components, including alpha
aCtx->core20fwd->glClearDepth (1.0);
aCtx->core20fwd->glClearColor (0.0f, 0.0f, 0.0f, aCtx->caps->buffersOpaqueAlpha ? 1.0f : 0.0f);
aCtx->core20fwd->glClear (GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
aCtx->SetColorMask (true); // restore default alpha component write state

5
tests/opengl/data/transparency/oit
View File

@ -36,6 +36,11 @@ vdump $imagedir/${casename}_weight.png
vrenderparams -oit peeling 4
vdump $imagedir/${casename}_peel.png
# test opaqueAlpha option - result should be the same
vcaps -opaqueAlpha 1
vdump $imagedir/${casename}_peel_rgb.png
vcaps -opaqueAlpha 0
# VTK viewer, just for comparison
set hasVtk 0
if { [vdriver -default] == "TKOpenGl" } {