OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-10 18:51:21 +03:00
Code Packages Releases Activity

0026406: BRepPrimAPI_MakeRevol crash when rotating Paraboloid face.

Browse Source 
Test-case for issue #26406
This commit is contained in:
ifv 2015-07-20 14:59:07 +03:00 committed by bugmaster
parent 679d4fa8ca
commit 4f0fb8b396
3 changed files with 281 additions and 238 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/BRepSweep/BRepSweep_Rotation.cxx
View File

@ -66,6 +66,8 @@
#include <TopoDS_Shape.hxx>
#include <TopoDS_Vertex.hxx>
#include <TopExp_Explorer.hxx>
static Standard_Real ComputeTolerance(TopoDS_Edge& E,
const TopoDS_Face& F,
const Handle(Geom2d_Curve)& C)
@ -221,14 +223,26 @@ TopoDS_Shape BRepSweep_Rotation::MakeEmptyGeneratingEdge
const Sweep_NumShape& aDirV)
{
//call in case of construction with copy, or only when meridian touches myaxe.
TopoDS_Edge E;
if(BRep_Tool::Degenerated(TopoDS::Edge(aGenE)))
{
myBuilder.Builder().MakeEdge(E);
myBuilder.Builder().UpdateEdge(E, BRep_Tool::Tolerance(TopoDS::Edge(aGenE)));
myBuilder.Builder().Degenerated(E, Standard_True);
}
else
{
Standard_Real First,Last;
TopLoc_Location Loc;
Handle(Geom_Curve) C = Handle(Geom_Curve)::DownCast
(BRep_Tool::Curve(TopoDS::Edge(aGenE),Loc,First,Last)->Copy());
if(!C.IsNull())
{
C->Transform(Loc.Transformation());
TopoDS_Edge E;
if(aDirV.Index() == 2) C->Transform(myLocation.Transformation());
}
myBuilder.Builder().MakeEdge(E,C,BRep_Tool::Tolerance(TopoDS::Edge(aGenE)));
}
if (aDirV.Index() == 1 &&
IsInvariant(aGenE) &&
myDirShapeTool.NbShapes() == 3) {
@ -723,6 +737,7 @@ Standard_Boolean BRepSweep_Rotation::GGDShapeIsToAdd
const TopoDS_Shape& aSubGenS,
const Sweep_NumShape& aDirS )const
{
Standard_Boolean aRes = Standard_True;
if (aNewShape.ShapeType()==TopAbs_FACE &&
aNewSubShape.ShapeType()==TopAbs_EDGE &&
aGenS.ShapeType()==TopAbs_EDGE &&
@ -734,11 +749,11 @@ Standard_Boolean BRepSweep_Rotation::GGDShapeIsToAdd
return (!IsInvariant(aSubGenS));
}
else{
return Standard_True;
return aRes;
}
}
else{
return Standard_True;
return aRes;
}
}
@ -835,20 +850,33 @@ Standard_Boolean BRepSweep_Rotation::HasShape
const Sweep_NumShape& aDirS)const
{
if(aDirS.Type()==TopAbs_EDGE&&
aGenS.ShapeType()==TopAbs_EDGE){
aGenS.ShapeType()==TopAbs_EDGE)
{
// Verify that the edge has entrails
const TopoDS_Edge& anEdge = TopoDS::Edge(aGenS);
Standard_Boolean hasGeom = !BRep_Tool::Degenerated(anEdge);
if (hasGeom)
{ // The edge is not degenerated. Check if it has no curve
//
if(BRep_Tool::Degenerated(anEdge)) return Standard_False;
Standard_Real aPFirst, aPLast;
TopLoc_Location aLoc;
Handle(Geom_Curve) aCurve = BRep_Tool::Curve(anEdge, aLoc, aPFirst, aPLast);
hasGeom = !aCurve.IsNull();
if(aCurve.IsNull()) return Standard_False;
if(IsInvariant(aGenS)) return Standard_False;
//Check seem edge
TopExp_Explorer FaceExp(myGenShape, TopAbs_FACE);
for (;FaceExp.More(); FaceExp.Next()) {
TopoDS_Face F = TopoDS::Face(FaceExp.Current());
if (BRepTools::IsReallyClosed(anEdge, F))
return Standard_False;
}
return hasGeom && !IsInvariant(aGenS);
return Standard_True;
}
else{
else
{
return Standard_True;
}
}

15
tests/bugs/modalg_6/bug26406 Normal file
View File

@ -0,0 +1,15 @@
puts "========"
puts "OCC26406"
puts "========"
puts ""
#############################################################
# BRepPrimAPI_MakeRevol crash when rotating Paraboloid face
#############################################################
smallview
restore [locate_data_file OCC26406-Paraboloid.brep] p
revol r p 0 0 0 0 0 1 180 c
checkshape r
set only_screen_axo 1