OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0023132: Suspicious code snippets

Browse Source 
1) Warning in Aspect.cxx couldn't be reproduced
2) Description of changes: added 'return' statements into ReadStep(...) functions of RWStepBasic_* classes.
3) BRepFill_OffsetWire.cxx - removed dead code;
4) IFSelect_WorkSession.cxx - swapped arguments;
5) TopOpeBRep_ShapeIntersector2d.cxx - removed 'brake' statement and changed loop to if-statement because of
     void TopOpeBRep_ShapeIntersector2d::FindFFIntersection() function's call features.
6) V2d_RectangularGraphicGrid.cxx - left constants instead of functions beacuse of faster perfomance.
7) Commented unreachable code in files GeomFill_LocationGuide.cxx and TopOpeBRepTool_mkTondgE.cxx
This commit is contained in:
omy
2012-11-16 13:30:31 +04:00
parent 49f38e37fc
commit 4e76d93bf1
15 changed files with 146 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/TopOpeBRepTool/TopOpeBRepTool_mkTondgE.cxx
View File

@@ -366,7 +366,7 @@ Standard_Boolean TopOpeBRepTool_mkTondgE::MkTonE(const TopoDS_Edge& ei, Standard
else mkT = outin ? MKI2 : MKI1;
return Standard_True;
////////////////////////////////////////////////
/*
// xxri :
Standard_Real ddot = tgin1di.Dot(faxis);
Standard_Boolean tgaxis = Abs(1-(Abs(ddot))) < FUN_tola(); //=true : edge is tangent to sphere's axis
@@ -378,7 +378,7 @@ Standard_Boolean TopOpeBRepTool_mkTondgE::MkTonE(const TopoDS_Edge& ei, Standard
if ((!onfi) && (!onli)) {mkT = MKI12; return Standard_True;} // @190499
if (closedi) {mkT = MKI12; return Standard_True;}// onfi || onli @190499
xxri = tgin1di;
}
}*/
}//!isT2d
mkT = MKI12; // without restrictions.
@@ -387,5 +387,7 @@ Standard_Boolean TopOpeBRepTool_mkTondgE::MkTonE(const TopoDS_Edge& ei, Standard
Standard_Boolean keepang = (dot > 0);
if (keepang) mkT = outin ? MKI1 : MKI2;
else mkT = outin ? MKI2 : MKI1;
return Standard_True;
}