OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-03 17:56:21 +03:00
Code Packages Releases Activity

0033743: Modeling Algorithm - fix crash with BRepFilletAPI_MakeChamfer

Browse Source 
Handle a case where a newly created face does not contain a required
edge. Since the null edge was passed in, the algorithm would eventually
crash when trying to access its members.
This commit is contained in:
Florian Foinant-Willig 2024-06-19 21:18:57 +02:00
parent 4c8faa5e2d
commit 4abf89322e
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ChFi3d/ChFi3d_Builder_2.cxx
View File

@ -1249,12 +1249,22 @@ ChFi3d_Builder::StartSol(const Handle(ChFiDS_Spine)& Spine,
TopoDS_Face newface = Fv; TopoDS_Face newface = Fv;
newface.Orientation(TopAbs_FORWARD); newface.Orientation(TopAbs_FORWARD);
TopExp_Explorer ex; TopExp_Explorer ex;
Standard_Boolean found = 0;
for(ex.Init(newface,TopAbs_EDGE); ex.More(); ex.Next()){ for(ex.Init(newface,TopAbs_EDGE); ex.More(); ex.Next()){
if(ex.Current().IsSame(E)){ if(ex.Current().IsSame(E)){
newedge = TopoDS::Edge(ex.Current()); newedge = TopoDS::Edge(ex.Current());
found = 1;
break; break;
} }
} }
if (!found){
// E not in newface, the state is preserved and False is returned
HS->Initialize(F);
W = CP.ParameterOnArc();
pc = BRep_Tool::CurveOnSurface(E,F,Uf,Ul);
pons = pc->Value(W);
return Standard_False;
}
HC->Initialize(newedge,Fv); HC->Initialize(newedge,Fv);
pons = HC->Value(W); pons = HC->Value(W);
HCref->Initialize(E,F); HCref->Initialize(E,F);