0024129: Eliminate remaining compiler warnings in MSVC++ 2008 32 bit with warning level 4

List of resolved warnings:

c4063: Aspect.cdl; TObj_Application.cxx; PCDM.cdl; OpenGl_Workspace_5.cxx;
c4100: XDEDRAW.cxx; ViewerTest_ViewerCommands.cxx; TopOpeBRep_FacesFiller_1.cxx; TopClass_Classifier3d.gxx; TDataStd_ReferenceArray.cxx; QABugs_19.cxx; IntPatch_ImpImpIntersection_5.gxx; HLRTopoBRep_DSFiller.cxx; HLRBRep_Data.lxx; DPrsStd_AISPresentationCommands.cxx; BRepMesh_Delaun.cxx;
c4127: BOPTools_AlgoTools2D.cxx; MAT_Mat.gxx; GeomFill_SweepSectionGenerator.cxx; BRepMesh_Delaun.cxx;
c4189: IntCurveSurface_Inter.gxx; IGESToBRep_BRepEntity.cxx; BRepMesh_Delaun.cxx; BRepAlgo_Loop.cxx; IntStart_SearchOnBoundaries_1.gxx;
c4190: Plugin_Macro.hxx;
c4389: Visual3d_View.cxx; TopOpeBRep/TopOpeBRep_vpr.cxx; TDataStd_BooleanArray.cxx; IntPatch_ALine.cxx;
c4701: BRepAlgo.cxx;
c4702: MNaming_NamingRetrievalDriver_1.cxx; MNaming_NamingRetrievalDriver_2.cxx; BRepClass3d_SolidExplorer.cxx;
c4706: TestTopOpe_BOOP.cxx;

Additional fixes:
- old-style declarations of C functions in IGES and STEP parsers
- clean-up of debug code, fixes for building in Debug mode
- in BRepFill_TrimShellCorner.cxx, lines 878-9, wrong use of assignment instead of comparison fixed
- fix for Plugin_Macro reverted; warning 4190 disabled instead
- in IntPatch_ALine.cxx, line 520, wrong comparison of boolean with index fixed
- in InterfaceGraphic_Visual3d.hxx, field IsCustomMatrix made boolean
- in TopOpeBRepBuild_ShapeSet, obsolete (unused) methods removed

src/TestTopOpe/TestTopOpe_BOOP.cxx

@@ -63,13 +63,25 @@ extern void PrintKRO_PREPA();
 
 Standard_Integer TestTopOpe_BOOP::Prepare(const char* ns1,const char* ns2)
 {
-  Standard_Integer err = 0;
-  if ((err = LoadShapes(ns1,ns2))) return err; // 0
-  if ((err = LoadnewDS())) return err; // 100
-  if ((err = DSF_Insert())) return err; // 100<,<200
-  if ((err = LoadnewHB())) return err; // 200
-  if ((err = Builder_Perform())) return err; // 200<,<300
-  return 0;
+  Standard_Integer anErrorCode = 0;
+  anErrorCode = LoadShapes(ns1,ns2);  // mylastPREP is 0
+  if (anErrorCode)
+    return anErrorCode;
+
+  anErrorCode = LoadnewDS();          // mylastPREP is 100
+  if (anErrorCode)
+    return anErrorCode;
+
+  anErrorCode = DSF_Insert();         // mylastPREP is (100,200)
+  if (anErrorCode)
+    return anErrorCode;
+
+  anErrorCode = LoadnewHB();          // mylastPREP is 200
+  if (anErrorCode)
+    return anErrorCode;
+
+  anErrorCode = Builder_Perform();    // mylastPREP is (200,300)
+  return anErrorCode;
 }
 
 Standard_Integer TestTopOpe_BOOP::LoadShapes(const char* ns1, const char* ns2)
@@ -95,7 +107,6 @@ Standard_Integer TestTopOpe_BOOP::LoadnewDS()
 
 Standard_Integer TestTopOpe_BOOP::DSF_Insert()
 {
-//  Standard_Integer err = 0;
   TopOpeBRep_DSFiller DSF;
   DSF_Insert(DSF);
   mylastPREP = 190;
@@ -104,7 +115,6 @@ Standard_Integer TestTopOpe_BOOP::DSF_Insert()
 
 Standard_Integer TestTopOpe_BOOP::LoadnewHB()
 {
-//  Standard_Integer err = 0;
   TopOpeBRepTool_GeomTool GT;
   Standard_Boolean c2d = myVarsTopo.GetC2D();
   GT.Define(myVarsTopo.GetOCT(),Standard_True,c2d, c2d);
@@ -118,7 +128,6 @@ Standard_Integer TestTopOpe_BOOP::LoadnewHB()
 
 Standard_Integer TestTopOpe_BOOP::Builder_Perform()
 {
-//  Standard_Integer err = 0;  
   myHB->Perform(myHDS,myS1,myS2);
 #ifdef DEB
   if ( TopOpeBRepTool_GettraceKRO() ) PrintKRO_PREPA();

src/TestTopOpe/TestTopOpe_BOOPCommands.cxx

@@ -322,18 +322,20 @@ Standard_Integer TOPOC(Draw_Interpretor& interpretor,Standard_Integer na,const c
 } // TOPO
 
 // ----------------------------------------------------------------------
+#ifdef DEB
 Standard_Integer BOOPCHK(Draw_Interpretor& ,Standard_Integer na,const char** a)
 {
   if (!strcmp(a[0],"tchk")) { 
-#ifdef DEB
 //    Standard_IMPORT extern Standard_Integer TopOpeBRepTool_BOOOPE_CHECK_DEB;
     Standard_IMPORT Standard_Integer TopOpeBRepTool_BOOOPE_CHECK_DEB;
     if ( na >= 2 ) TopOpeBRepTool_BOOOPE_CHECK_DEB = (Draw::Atoi(a[1])) ? 1 : 0;
-#endif
     return 0;
   }
   return 0;
 }
+#else
+Standard_Integer BOOPCHK(Draw_Interpretor& ,Standard_Integer,const char**) {return 0;}
+#endif
 
 // ----------------------------------------------------
 Standard_Integer TOPOSETCOMMANDS(TestTopOpe_BOOP& PT,Standard_Integer na,const char** a, Draw_Interpretor& di)