OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-19 13:40:49 +03:00
Code Activity

0026872: Coding - pointless instantiations of local variables in BinTools

Browse Source 
Instantiations of local stringstream variables used in error handling moved from upper function scope to places where they are actually needed
This commit is contained in:
abv
2015-11-15 09:11:52 +03:00
committed by bugmaster
parent eece3af2e2
commit 4525373bf3
4 changed files with 27 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/BinTools/BinTools_SurfaceSet.cxx
View File

@@ -383,7 +383,6 @@ static Standard_OStream& operator <<(Standard_OStream& OS, const Handle(Geom_Off
void BinTools_SurfaceSet::WriteSurface(const Handle(Geom_Surface)& S,
Standard_OStream& OS)
{
Standard_SStream aMsg;
Handle(Standard_Type) TheType = S->DynamicType();
try {
OCC_CATCH_SIGNALS
@@ -421,11 +420,11 @@ void BinTools_SurfaceSet::WriteSurface(const Handle(Geom_Surface)& S,
OS << Handle(Geom_OffsetSurface)::DownCast(S);
}
else {
aMsg <<"UNKNOWN SURFACE TYPE" <<endl;
Standard_Failure::Raise(aMsg);
Standard_Failure::Raise("UNKNOWN SURFACE TYPE");
}
}
catch(Standard_Failure) {
Standard_SStream aMsg;
aMsg << "EXCEPTION in BinTools_SurfaceSet::WriteSurface(..)" << endl;
Handle(Standard_Failure) anExc = Standard_Failure::Caught();
aMsg << anExc << endl;
@@ -759,7 +758,6 @@ static Standard_IStream& operator>>(Standard_IStream& IS,
Standard_IStream& BinTools_SurfaceSet::ReadSurface(Standard_IStream& IS,
Handle(Geom_Surface)& S)
{
Standard_SStream aMsg;
try {
OCC_CATCH_SIGNALS
const Standard_Byte stype = (Standard_Byte) IS.get();
@@ -856,14 +854,14 @@ Standard_IStream& BinTools_SurfaceSet::ReadSurface(Standard_IStream& IS,
default :
{
S = NULL;
aMsg << "UNKNOWN SURFACE TYPE" << endl;
Standard_Failure::Raise(aMsg);
Standard_Failure::Raise("UNKNOWN SURFACE TYPE");
}
break;
}
}
catch(Standard_Failure) {
S = NULL;
Standard_SStream aMsg;
aMsg << "EXCEPTION in BinTools_SurfaceSet::ReadSurface(..)" << endl;
Handle(Standard_Failure) anExc = Standard_Failure::Caught();
aMsg << anExc << endl;