OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-06 18:26:22 +03:00
Code Packages Releases Activity

0027441: The method IntTools_Context::IsVertexOnLine incorrectly computes parameter of the point on the curve

Browse Source 
Choosing the closest bound to the checking point.
This commit is contained in:
emv 2016-04-27 16:28:52 +03:00 committed by apn
parent 320a322080
commit 416022a12f
2 changed files with 32 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/IntTools/IntTools_Context.cxx
View File

@ -840,14 +840,19 @@ Standard_Boolean IntTools_Context::IsVertexOnLine
aFirst=aC3D->FirstParameter(); aFirst=aC3D->FirstParameter();
aLast =aC3D->LastParameter(); aLast =aC3D->LastParameter();
// //
//Checking extermities first // Checking extermities first
// It is necessary to chose the closest bound to the point
Standard_Boolean bFirstValid = Standard_False;
Standard_Real aFirstDist = Precision::Infinite();
//
if (!Precision::IsInfinite(aFirst)) { if (!Precision::IsInfinite(aFirst)) {
gp_Pnt aPCFirst=aC3D->Value(aFirst); gp_Pnt aPCFirst=aC3D->Value(aFirst);
aDist=aPv.Distance(aPCFirst); aFirstDist = aPv.Distance(aPCFirst);
if (aDist < aTolSum) { if (aFirstDist < aTolSum) {
bFirstValid = Standard_True;
aT=aFirst; aT=aFirst;
// //
if(aDist > aTolV) { if (aFirstDist > aTolV) {
Extrema_LocateExtPC anExt(aPv, aGAC, aFirst, 1.e-10); Extrema_LocateExtPC anExt(aPv, aGAC, aFirst, 1.e-10);
if(anExt.IsDone()) { if(anExt.IsDone()) {
@ -889,15 +894,16 @@ Standard_Boolean IntTools_Context::IsVertexOnLine
} }
} }
//
return Standard_True;
} }
} }
// //
//if (!Precision::IsInfinite(aFirst)) {
if (!Precision::IsInfinite(aLast)) { if (!Precision::IsInfinite(aLast)) {
gp_Pnt aPCLast=aC3D->Value(aLast); gp_Pnt aPCLast=aC3D->Value(aLast);
aDist=aPv.Distance(aPCLast); aDist=aPv.Distance(aPCLast);
if (bFirstValid && (aFirstDist < aDist)) {
return Standard_True;
}
//
if (aDist < aTolSum) { if (aDist < aTolSum) {
aT=aLast; aT=aLast;
// //
@ -946,6 +952,9 @@ Standard_Boolean IntTools_Context::IsVertexOnLine
return Standard_True; return Standard_True;
} }
} }
else if (bFirstValid) {
return Standard_True;
}
// //
GeomAPI_ProjectPointOnCurve& aProjector=ProjPT(aC3D); GeomAPI_ProjectPointOnCurve& aProjector=ProjPT(aC3D);
aProjector.Perform(aPv); aProjector.Perform(aPv);

16
tests/bugs/modalg_6/bug27441 Normal file
View File

@ -0,0 +1,16 @@
puts "============"
puts "OCC27441"
puts "============"
puts ""
###############################
## The method IntTools_ContextIsVertexOnLine incorrectly computes parameter of the point on the curve
###############################
restore [locate_data_file bug27428_shapes.brep] b
explode b
bsection result b_1 b_2
set bcheck [bopcheck result]
puts $bcheck
if {![regexp {This shape seems to be OK.} $bcheck]} {
puts "Error: bopcheck failed"
}