OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-14 13:30:48 +03:00
Code Activity

0027909: Modeling Algorithms - Exception during offset computation

Browse Source 
Added function ChFi3d::IsTangentFaces for more accurate definition of connection type.
Test cases have been changed according to the current behavior.
This commit is contained in:
akaftasev
2020-05-12 12:21:59 +03:00
committed by bugmaster
parent e8e8b273bb
commit 3f54cc41a8
35 changed files with 212 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/BRepOffset/BRepOffset_Analyse.cxx
View File

@@ -89,28 +89,37 @@ static void EdgeAnalyse(const TopoDS_Edge& E,
const Standard_Real SinTol,
BRepOffset_ListOfInterval& LI)
{
Standard_Real f,l;
BRep_Tool::Range(E, F1, f, l);
BRepOffset_Interval I;
I.First(f); I.Last(l);
//
// Tangent if the regularity is at least G1.
if (BRep_Tool::HasContinuity(E,F1,F2)) {
if (BRep_Tool::Continuity(E,F1,F2) > GeomAbs_C0) {
I.Type(ChFiDS_Tangential);
LI.Append(I);
return;
}
}
//
ChFiDS_TypeOfConcavity aType = ChFi3d::DefineConnectType(E, F1, F2,
SinTol, Standard_False);
if(aType != ChFiDS_Tangential)
//
BRepAdaptor_Surface aBAsurf1(F1, Standard_False);
GeomAbs_SurfaceType aSurfType1 = aBAsurf1.GetType();
BRepAdaptor_Surface aBAsurf2(F2, Standard_False);
GeomAbs_SurfaceType aSurfType2 = aBAsurf2.GetType();
Standard_Boolean isTwoPlanes = (aSurfType1 == GeomAbs_Plane && aSurfType2 == GeomAbs_Plane);
ChFiDS_TypeOfConcavity ConnectType = ChFiDS_Other;
if (isTwoPlanes) //then use only strong condition
{
aType = ChFi3d::DefineConnectType(E, F1, F2, SinTol, Standard_True);
if (BRep_Tool::Continuity(E,F1,F2) > GeomAbs_C0)
ConnectType = ChFiDS_Tangential;
else
ConnectType = ChFi3d::DefineConnectType(E, F1, F2, SinTol, Standard_False);
}
I.Type(aType);
else
{
if (ChFi3d::IsTangentFaces(E, F1, F2)) //weak condition
ConnectType = ChFiDS_Tangential;
else
ConnectType = ChFi3d::DefineConnectType(E, F1, F2, SinTol, Standard_False);
}
I.Type(ConnectType);
LI.Append(I);
}

2
src/BRepOffset/BRepOffset_MakeOffset.cxx
View File

@@ -4098,7 +4098,7 @@ void TrimEdge(TopoDS_Edge& NE,
gp_Pnt thePoint = BRep_Tool::Pnt(V);
GeomAPI_ProjectPointOnCurve Projector(thePoint, theCurve);
if (Projector.NbPoints() == 0)
throw Standard_ConstructionError("BRepOffset_MakeOffset::TrimEdge no projection");
return;
U = Projector.LowerDistanceParameter();
}
if (U < UMin) {