0025735: Wrong solid is considered as valid by checkshape

Changes:
class BRepCheck_Solid
method:
   void BRepCheck_Solid::Minimum()
has been changed. The treatment of shells with INTERNAL faces has been added.

Added test case bugs/modalg_5/bug25735

Added TODOs in test cases according to issue 25735.

src/BRepCheck/BRepCheck_Solid.cxx

@@ -197,7 +197,7 @@ void BRepCheck_Solid::Minimum()
   myMin = Standard_True;
   //
   Standard_Boolean bFound, bIsHole, bFlag;
-  Standard_Integer i, j, aNbVTS, aNbVTS1;
+  Standard_Integer i, j, aNbVTS, aNbVTS1, iCntSh, iCntShInt;
   TopoDS_Solid aZ;
   TopoDS_Iterator aIt, aItF;
   TopoDS_Builder aBB;
@@ -228,6 +228,8 @@ void BRepCheck_Solid::Minimum()
   // 2. 
   //    - Too many growths,
   //    - There is smt of the solid that is out of solid
+  iCntSh=0;
+  iCntShInt=0;
   aIt.Initialize(myShape);
   for (; aIt.More(); aIt.Next()) {
     const TopoDS_Shape& aSx=aIt.Value();
@@ -254,9 +256,12 @@ void BRepCheck_Solid::Minimum()
       }
     }
     if (bFound) {
+      ++iCntShInt;
       continue;
     }
     //
+    ++iCntSh;
+    //
     // Skip not closed shells
     if (!BRep_Tool::IsClosed(aSh)) {
       continue;
@@ -271,6 +276,12 @@ void BRepCheck_Solid::Minimum()
     aVTS.Append(aTS);
   }//for (; aIt.More(); aIt.Next()) {
   //
+  if (!iCntSh && iCntShInt) {
+    // all shells in the solid are internal
+    BRepCheck::Add(myMap(myShape), 
+                   BRepCheck_BadOrientationOfSubshape);
+  }
+  //
   aNbVTS=aVTS.Size();
   if (aNbVTS<2) {
     return;

tests/boolean/bcut_complex/O3

@@ -1,4 +1,5 @@
 puts "TODO #22911 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file CTO908_topo101-o1.brep] obj1
 restore [locate_data_file CTO908_topo101-t1.brep] tool1

tests/boolean/bcut_complex/O4

@@ -1,4 +1,5 @@
 puts "TODO #22911 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file CTO908_topo101-o2.brep] obj2
 restore [locate_data_file CTO908_topo101-t2.brep] tool2

tests/boolean/bcut_complex/O5

@@ -1,4 +1,5 @@
 puts "TODO #22911 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file CTO908_topo102-o.brep] obj
 restore [locate_data_file CTO908_topo102-t.brep] tool

tests/boolean/bcut_complex/O6

@@ -1,4 +1,5 @@
 puts "TODO #22911 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file CTO908_topo103-o.brep] obj
 restore [locate_data_file CTO908_topo103-t.brep] tool

tests/boolean/bfuse_complex/O5

@@ -1,3 +1,5 @@
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 restore [locate_data_file CTO908_topo104-o1.brep] wheel
 restore [locate_data_file CTO908_topo104-o2.brep] jante
 

tests/boolean/bfuse_complex/O6

@@ -1,3 +1,5 @@
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 restore [locate_data_file CTO908_topo106-p.brep] poche
 restore [locate_data_file CTO908_topo106-n.brep] nervure
 

tests/boolean/bopfuse_complex/H1

@@ -1,4 +1,5 @@
 puts "TODO #22911 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file a102] a
 restore [locate_data_file b136] b

tests/boolean/boptuc_complex/D5

@@ -1,4 +1,5 @@
 puts "TODO ?OCC24925 ALL: Error : The area of the resulting shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
 
 restore [locate_data_file a102] a
 restore [locate_data_file b136] b

tests/bugs/modalg_2/bug497_3

@@ -1,3 +1,5 @@
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "========="
 puts " OCC497 "
 puts "(case 3)"

tests/bugs/modalg_4/bug62

@@ -1,4 +1,6 @@
 puts "TODO ?OCC12345 ALL: Error : The square of result shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "================"
 puts "OCC62"
 puts "BUC61001"

tests/bugs/modalg_4/bug697_2

@@ -1,4 +1,6 @@
 puts "TODO OCC12345 ALL: Error : The square of result shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "============"
 puts "OCC697"
 puts "============"

tests/bugs/modalg_4/bug697_4

@@ -1,4 +1,6 @@
 puts "TODO OCC12345 ALL: Error : The square of result shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "============"
 puts "OCC697"
 puts "============"

tests/bugs/modalg_4/bug697_7

@@ -1,4 +1,6 @@
 puts "TODO OCC12345 ALL: Error : The square of result shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "============"
 puts "OCC697"
 puts "============"

tests/bugs/modalg_4/bug697_8

@@ -1,4 +1,6 @@
 puts "TODO OCC12345 ALL: Error : The square of result shape is"
+puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
+
 puts "============"
 puts "OCC697"
 puts "============"

tests/bugs/modalg_5/bug25735

@@ -0,0 +1,21 @@
+puts "=========="
+puts "OCC25735"
+puts "=========="
+puts ""
+######################################################
+# Wrong solid is considered as valid by checkshape
+######################################################
+
+restore [locate_data_file bug25735_r5] result
+
+decho off
+set info [checkshape result]
+decho on
+
+if { [regexp "Faulty shapes in variables faulty_1" ${info}] != 1 } {
+  puts "Error : There are no mistakes by checkshape-command"
+} else {
+  puts "OK : There are mistakes by checkshape-command"
+}
+
+set 2dviewer 1