OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-04-04 18:06:22 +03:00
Code Packages Releases Activity

0025735: Wrong solid is considered as valid by checkshape

Browse Source 
Changes:
class BRepCheck_Solid
method:
   void BRepCheck_Solid::Minimum()
has been changed. The treatment of shells with INTERNAL faces has been added.

Added test case bugs/modalg_5/bug25735

Added TODOs in test cases according to issue 25735.
This commit is contained in:
pkv 2015-02-05 12:49:05 +03:00 committed by bugmaster
parent 4e0311752a
commit 34a0b4463a
16 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/BRepCheck/BRepCheck_Solid.cxx
View File

@ -197,7 +197,7 @@ void BRepCheck_Solid::Minimum()
myMin = Standard_True;
//
Standard_Boolean bFound, bIsHole, bFlag;
Standard_Integer i, j, aNbVTS, aNbVTS1;
Standard_Integer i, j, aNbVTS, aNbVTS1, iCntSh, iCntShInt;
TopoDS_Solid aZ;
TopoDS_Iterator aIt, aItF;
TopoDS_Builder aBB;
@ -228,6 +228,8 @@ void BRepCheck_Solid::Minimum()
// 2.
// - Too many growths,
// - There is smt of the solid that is out of solid
iCntSh=0;
iCntShInt=0;
aIt.Initialize(myShape);
for (; aIt.More(); aIt.Next()) {
const TopoDS_Shape& aSx=aIt.Value();
@ -254,9 +256,12 @@ void BRepCheck_Solid::Minimum()
}
}
if (bFound) {
++iCntShInt;
continue;
}
//
++iCntSh;
//
// Skip not closed shells
if (!BRep_Tool::IsClosed(aSh)) {
continue;
@ -271,6 +276,12 @@ void BRepCheck_Solid::Minimum()
aVTS.Append(aTS);
}//for (; aIt.More(); aIt.Next()) {
//
if (!iCntSh && iCntShInt) {
// all shells in the solid are internal
BRepCheck::Add(myMap(myShape),
BRepCheck_BadOrientationOfSubshape);
}
//
aNbVTS=aVTS.Size();
if (aNbVTS<2) {
return;

1
tests/boolean/bcut_complex/O3
View File

@ -1,4 +1,5 @@
puts "TODO #22911 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo101-o1.brep] obj1
restore [locate_data_file CTO908_topo101-t1.brep] tool1

1
tests/boolean/bcut_complex/O4
View File

@ -1,4 +1,5 @@
puts "TODO #22911 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo101-o2.brep] obj2
restore [locate_data_file CTO908_topo101-t2.brep] tool2

1
tests/boolean/bcut_complex/O5
View File

@ -1,4 +1,5 @@
puts "TODO #22911 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo102-o.brep] obj
restore [locate_data_file CTO908_topo102-t.brep] tool

1
tests/boolean/bcut_complex/O6
View File

@ -1,4 +1,5 @@
puts "TODO #22911 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo103-o.brep] obj
restore [locate_data_file CTO908_topo103-t.brep] tool

2
tests/boolean/bfuse_complex/O5
View File

@ -1,3 +1,5 @@
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo104-o1.brep] wheel
restore [locate_data_file CTO908_topo104-o2.brep] jante

2
tests/boolean/bfuse_complex/O6
View File

@ -1,3 +1,5 @@
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file CTO908_topo106-p.brep] poche
restore [locate_data_file CTO908_topo106-n.brep] nervure

1
tests/boolean/bopfuse_complex/H1
View File

@ -1,4 +1,5 @@
puts "TODO #22911 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file a102] a
restore [locate_data_file b136] b

1
tests/boolean/boptuc_complex/D5
View File

@ -1,4 +1,5 @@
puts "TODO ?OCC24925 ALL: Error : The area of the resulting shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
restore [locate_data_file a102] a
restore [locate_data_file b136] b

2
tests/bugs/modalg_2/bug497_3
View File

@ -1,3 +1,5 @@
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "========="
puts " OCC497 "
puts "(case 3)"

2
tests/bugs/modalg_4/bug62
View File

@ -1,4 +1,6 @@
puts "TODO ?OCC12345 ALL: Error : The square of result shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "================"
puts "OCC62"
puts "BUC61001"

2
tests/bugs/modalg_4/bug697_2
View File

@ -1,4 +1,6 @@
puts "TODO OCC12345 ALL: Error : The square of result shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "============"
puts "OCC697"
puts "============"

2
tests/bugs/modalg_4/bug697_4
View File

@ -1,4 +1,6 @@
puts "TODO OCC12345 ALL: Error : The square of result shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "============"
puts "OCC697"
puts "============"

2
tests/bugs/modalg_4/bug697_7
View File

@ -1,4 +1,6 @@
puts "TODO OCC12345 ALL: Error : The square of result shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "============"
puts "OCC697"
puts "============"

2
tests/bugs/modalg_4/bug697_8
View File

@ -1,4 +1,6 @@
puts "TODO OCC12345 ALL: Error : The square of result shape is"
puts "TODO OCC25735 ALL: Faulty shapes in variables faulty_1 to"
puts "============"
puts "OCC697"
puts "============"

21
tests/bugs/modalg_5/bug25735 Normal file
View File

@ -0,0 +1,21 @@
puts "=========="
puts "OCC25735"
puts "=========="
puts ""
######################################################
# Wrong solid is considered as valid by checkshape
######################################################
restore [locate_data_file bug25735_r5] result
decho off
set info [checkshape result]
decho on
if { [regexp "Faulty shapes in variables faulty_1" ${info}] != 1 } {
puts "Error : There are no mistakes by checkshape-command"
} else {
puts "OK : There are mistakes by checkshape-command"
}
set 2dviewer 1