OpenCascade/occt
1
0
Fork 0
mirror of https://git.dev.opencascade.org/repos/occt.git synced 2025-08-09 13:22:24 +03:00
Code Activity

0031144: Shape Healing - ShapeAnalysis::OuterWire() infinite loop on solid obtained from IFC

Browse Source 
Implementation of ShapeAnalysis::OuterWire() is revised to avoid infinite cycle if face contains internal vertex.
This commit is contained in:
abv
2019-11-12 19:10:14 +03:00
committed by bugmaster
parent bf97419a18
commit 31a5a359bb
2 changed files with 38 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/ShapeAnalysis/ShapeAnalysis.cxx
View File

@@ -241,9 +241,10 @@ Standard_Boolean ShapeAnalysis::IsOuterBound(const TopoDS_Face& face)
//=======================================================================
//function : OuterBound
//purpose : replacement of bad BRepTools::OuterBound()
//purpose : replacement of bad BRepTools::OuterBound(), to be merged
// - skips internal vertices in face, if any, without exception
// - returns positively oriented wire rather than greater one
//=======================================================================
//:n3
TopoDS_Wire ShapeAnalysis::OuterWire(const TopoDS_Face& face)
{
@@ -251,21 +252,26 @@ TopoDS_Wire ShapeAnalysis::OuterWire(const TopoDS_Face& face)
F.Orientation(TopAbs_FORWARD);
BRep_Builder B;
TopoDS_Wire W;
TopoDS_Iterator exp (F, Standard_False);
while ( exp.More() ) {
if(exp.Value().ShapeType() != TopAbs_WIRE)
TopoDS_Iterator anIt (F, Standard_False);
while (anIt.More())
{
TopoDS_Shape aWire = anIt.Value();
anIt.Next();
// skip possible internal vertices in face
if (aWire.ShapeType() != TopAbs_WIRE)
continue;
W = TopoDS::Wire ( exp.Value() );
exp.Next();
if ( ! exp.More() ) return W;
//szv#4:S4163:12Mar99 SGI warns
TopoDS_Shape sh = F.EmptyCopied();
TopoDS_Face fc = TopoDS::Face( sh );
B.Add ( fc, W );
if ( ShapeAnalysis::IsOuterBound ( fc ) ) return W;
// if current wire is the last one, return it without analysis
if (! anIt.More())
return TopoDS::Wire (aWire);
TopoDS_Shape aTestFace = F.EmptyCopied();
B.Add (aTestFace, aWire);
if (ShapeAnalysis::IsOuterBound (TopoDS::Face (aTestFace)))
return TopoDS::Wire (aWire);
}
return W;
return TopoDS_Wire();
}
//=======================================================================