0023947: Eliminate trivial compiler warnings in MSVC++ with warning level 4

Fix first subset of warnings (about 100)
- while(1) and similar constructs replaced by for(;;)
- some uninitialized variables corrected
Got rid of Warning C4189: local variable is initialised but not referenced
Corrected mistakes after getting rid of C4189 compiler warning
Corrected some mistakes that led to compiling errors
Fixed test case because of improvement message - removed unnecessary TODO.
Small fix: tabs have been replaced with whitespaces.
Added TODO for Windows platform
removed last TODO
Corrected mistakes, returned some #ifdef DEB code, fixed test case .
Restoring a few places which have been modified too much
Small grammar fix
Deleted unnecessary puts in bugs/end

src/IntTools/IntTools_BeanBeanIntersector.cxx

@@ -1305,7 +1305,7 @@ Standard_Integer FindMaxDistPC(const Standard_Real aT1A,
     return iErr;
   }
   //
-  while(1) {
+  for(;;) {
     if (aYP>aYL) {
       aA=aXL;
       aXL=aXP;

src/IntTools/IntTools_BeanFaceIntersector.cxx

@@ -898,7 +898,6 @@ Standard_Integer IntTools_BeanFaceIntersector::FastComputeExactIntersection()
       aTolang2=1.e-16;
       aLin=myCurve.Line();
       const gp_Dir& aDirL=aLin.Direction();
-      const gp_Pnt& aLocL=aLin.Location();
       //
       aCos=aDirC.Dot(aDirL);
       if(aCos >= 0.) {

src/IntTools/IntTools_EdgeEdge.cxx

@@ -585,7 +585,7 @@ IntTools_EdgeEdge::IntTools_EdgeEdge()
   Standard_Integer step = 1, stepcheck = 1000, steplimit = 100000;
   Standard_Real value = (IP==1) ? DistanceFunction(0.5*(a+b)) : DerivativeFunction(0.5*(a+b));
   
-  while (1) {
+  for(;;) {
     x0=.5*(a+b);
 
     if (IP==1)

src/IntTools/IntTools_EdgeEdge_1.cxx

@@ -323,7 +323,7 @@ void IntTools_ComparatorCurve::GetCurveBase(const Handle(Geom_Curve)& aC3D,
     return;
   }
   //
-  while(1) {
+  for(;;) {
     iTrimmed=0;
     iOffset=0;
     aCT3D=Handle(Geom_TrimmedCurve)::DownCast(aC3DB);
@@ -795,7 +795,7 @@ void IntTools_DistCC::FindMaxLocal(const Standard_Real aT11,
     return;
   }
   //
-  while(1) {
+  for(;;) {
     if (fabs(aA-aB)<aEps) {
       aX=0.5*(aA+aB);
       aF=Distance(aX);

src/IntTools/IntTools_EdgeFace.cxx

@@ -391,7 +391,7 @@ void IntTools_EdgeFace::CheckData()
   anIsProj1=ff1;
   anIsProj2=ff2;
   
-  while (1) {
+  for(;;) {
     if (fabs(t1-t2) < aEpsT) {
       tRoot=(anIsProj1) ? t1 : t2;
       return;
@@ -781,7 +781,7 @@ void IntTools_EdgeFace::CheckData()
   
   a=tA; b=tB; r=fA;
   
-  while (1) {
+  for(;;) {
     x0=.5*(a+b);
 
     if (IP==1)
@@ -825,7 +825,7 @@ void IntTools_EdgeFace::CheckData()
   yl=coeff*DistanceFunction(xl);
   
  
-  while (1) {
+  for(;;) {
     
     if (fabs(b-a) < myEpsT) {
       return .5*(b+a);

src/IntTools/IntTools_FClass2d.cxx

@@ -592,7 +592,7 @@ IntTools_FClass2d::IntTools_FClass2d()
     }//if (IsVPer) {
   }
 
-  while (1) {
+  for(;;) {
     dedans = 1;
     gp_Pnt2d Puv(u,v);
       

src/IntTools/IntTools_FaceFace.cxx

@@ -4835,7 +4835,7 @@ Standard_Real FindMaxSquareDistance (const Standard_Real aT1,
   aF2=MaxSquareDistance(aX2, 
 			aC3D, aC2D1, aC2D2, myHS1, myHS2, myFace1, myFace2, myContext);
   //
-  while(1) {
+  for(;;) {
     //
     if (fabs(aA-aB)<aEps) {
       aX=0.5*(aA+aB);